Allow logging in with email address on site + username reminder on pw reset #131
+84
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…added username reminder on emails too
Contributor
|
I prefer not to include the user name in the email. Some of them are really inappropriate and we want to avoid that in an outgoing email from us. Now that we allow the user to login with email, if they want to know it, they can login and find out from the profile page |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to log in with either username or email (where the email takes precedence) and reminds the user of their username during password reset flow to help remember their credentials.
I've added registration cross-checks to prevent registering a username that matches an existing user's email, and prevent registering an email that matches an existing user's username. These have generic error messages to avoid information leaking.
This PR is a draft until @xusheng6 tests, as I can't easily test with the email system.
This PR closes #97