Conversation
amotl
changed the title
orjson to improve JSON marshalling performanceorjson to improve JSON marshalling performance
amotl
force-pushed
the
orjson
branch
4 times, most recently
from
2a43b26 to
c92e27b
Compare
amotl
commented
Jan 15, 2025
seut
approved these changes
Jan 16, 2025
amotl
commented
Jan 16, 2025
Member
Author
amotl
left a comment
amotl
left a comment
There was a problem hiding this comment.
Hi again. Thanks for the quick review. I've just added a few thoughts about the consequences of removing the traditional CrateJsonEncoder.
amotl
commented
Jan 16, 2025
This was referenced Jan 16, 2025
amotl
commented
Jan 16, 2025
amotl
force-pushed
the
orjson
branch
3 times, most recently
from
5b8b18c to
402cdde
Compare
amotl
commented
Jan 16, 2025
amotl
commented
Jan 16, 2025
Member
|
Do we have a benchmark? |
surister
approved these changes
Jan 16, 2025
Member
Author
It's not a benchmark, but @widmogrod shared a flamegraph before/after over at #689 (comment). |
amotl
force-pushed
the
orjson
branch
2 times, most recently
from
c779801 to
dd81035
Compare
amotl
commented
Jan 16, 2025
amotl
commented
Jan 16, 2025
This was referenced Jan 16, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This was referenced Jan 17, 2025
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
Using orjson for JSON marshalling can yield performance wins. It has been used in CrateDB Toolkit already, in that case its sister library orjsonl. Thanks, @widmogrod.
References
Downstream
crate-2.0.0, which usesorjsonfor JSON marshalling crash#459crate-2.0.0, which usesorjsonfor JSON marshalling cratedb-toolkit#349crate-2.0.0, which usesorjsonfor JSON marshalling cratedb-examples#811crate-2.0.0, which usesorjsonfor JSON marshalling sqlalchemy-cratedb#195crate-2.0.0, which usesorjsonfor JSON marshalling langchain-cratedb#23crate-2.0.0, which usesorjsonfor JSON marshalling academy-fundamentals-course#49