Skip to content

Remove py < 3.9 deps; Mention dropped python version support in changes #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfussenegger merged 1 commit into from
Jan 20, 2026
+7 −12
Merged

Remove py < 3.9 deps; Mention dropped python version support in changes #769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,11 @@ Changes for crate

Unreleased
==========
- Modernize project definition to latest Python best practices. Thanks, @surister.
- Exceptions: Exceptions from the BLOB API now include their full names.

- Exceptions from the BLOB API now include their full names.

- Dropped support for Python versions earlier than 3.10 as they've reached
their end of life.

2025/01/30 2.0.0
================
Expand Down
2 changes: 0 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,13 @@ classifiers = [
"Topic :: System :: Networking",
]
dependencies = [
"importlib-metadata; python_version<'3.8'",
"orjson",
"urllib3",
"verlib2>=0.3.1",
]

[dependency-groups]
dev = [
"backports.zoneinfo<1; python_version<'3.9'",
Comment on lines 51 to -60
Copy link
Member

@amotl amotl Jan 20, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. This would contradict the other patch.

Copy link
Member

@amotl amotl Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel an urge to leave older Python versions behind, contrary to GH-759, and I don't want to provide stop energy. I have a different stance, but we can elaborate later.

"certifi",
"coverage",
"mypy<1.20",
Expand Down
10 changes: 2 additions & 8 deletions tests/client/test_cursor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,22 +20,16 @@
# software solely pursuant to the terms of the relevant commercial agreement.

import datetime
import zoneinfo
from ipaddress import IPv4Address
from unittest import mock

import pytest

from crate.client.exceptions import ProgrammingError

try:
import zoneinfo
except ImportError:
from backports import zoneinfo

import pytz

from crate.client import connect
from crate.client.converter import DataType, DefaultTypeConverter
from crate.client.exceptions import ProgrammingError


def test_cursor_fetch(mocked_connection):
Expand Down
Loading