Skip to content

feat: W3C revocation support #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tipusinghaw wants to merge 44 commits into
base: develop
Choose a base branch
from
Open

feat: W3C revocation support #262

tipusinghaw wants to merge 44 commits into from

Conversation

@tipusinghaw
Copy link
Contributor

@tipusinghaw tipusinghaw commented Apr 8, 2025

What

  • Added support for revocation in credo-controller
  • Added logic to create, sign, and upload BSLC
  • Added a method to get unused BSLC index

pranalidhanavade and others added 15 commits March 6, 2025 12:18
@pranalidhanavade
Resolve linting issues
b41855d 
Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
@KambleSahil3
chore: Update Dockerfile (#254)
4201556 
Signed-off-by: sahil.kamble@ayanworks.com <sahil.kamble@ayanworks.com>
Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>
@pranalidhanavade @KambleSahil3
fix: resolved prettier errors
884264b 
* Resolve linting issues

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>

* Resolve prettier issues

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>

---------

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>
@KambleSahil3
chore: Update Dockerfile (#256)
99fb113 
Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>
@pranalidhanavade @KambleSahil3
fix: resolved prettier errors in compass.yml file
72bbc53 
Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>
@KambleSahil3
feat: push docker image (#257)
0db0c91 
* feat: added yml file to push docker images to github

Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>

* feat: added yml file to push docker images to github

Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>

* fix: updated cicd.yml file

Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>

* fix: renamed yml file

Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>

---------

Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>
@KambleSahil3
feat/push-docker-image (#258)
9383784 
* feat: added yml file to push docker images to github

Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>

* feat: added yml file to push docker images to github

Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>

* fix: updated cicd.yml file

Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>

* fix: renamed yml file

Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>

* chore: removed id-token and attestations

Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>

* chore: removed id-token and attestations

Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>

---------

Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>
@tipusinghaw
feat:w3c-revocation
08a04a4 
Signed-off-by: Tipu_Singh <tipu.singh@ayanworks.com>
@tipusinghaw
refactor: removed revocation code
628296c 
Signed-off-by: Tipu_Singh <tipu.singh@ayanworks.com>
@tipusinghaw
refactore: removed constant and enum
ee9b63d 
Signed-off-by: Tipu_Singh <tipu.singh@ayanworks.com>
@tipusinghaw
Merge pull request #261 from credebl/refactor/w3c-revocation-v1
d54d66e 
revert: revocation code
@tipusinghaw
w3c revocation changes
ea58a19 
Signed-off-by: Tipu_Singh <tipu.singh@ayanworks.com>
@tipusinghaw
refactor: get index method
2d26e62 
Signed-off-by: Tipu_Singh <tipu.singh@ayanworks.com>
@tipusinghaw
refactor: solved sonar cloud issue
b518e46 
Signed-off-by: Tipu_Singh <tipu.singh@ayanworks.com>
@tipusinghaw
refactor: changes randomness logic to get unused index
d3dfc46 
Signed-off-by: Tipu_Singh <tipu.singh@ayanworks.com>
@tipusinghaw tipusinghaw self-assigned this Apr 8, 2025
@tipusinghaw tipusinghaw requested review from GHkrishna, amitpadmani-awts and sairanjit and removed request for amitpadmani-awts April 8, 2025 03:43
@tipusinghaw
fix: revocation issue
d640319 
Signed-off-by: Tipu_Singh <tipu.singh@ayanworks.com>
sairanjit
sairanjit requested changes Apr 9, 2025
View reviewed changes
Copy link
Member

@sairanjit sairanjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great addition. Just few things

  • I think there are a lot of API calls inside the functions related to statuslist. We should separate that out into module and use them in Dedicated and Multitenant controllers
  • Keeping statuslist into separate module will be easy to track and do the required changes

src/constants.ts
@@ -0,0 +1,2 @@
export const initialBitsEncoded = `uH4sIAAAAAAAAA-3BMQEAAADCoPVPbQwfoAAAAAAAAAAAAAAAAAAAAIC3AYbSVKsAQAAA`
Copy link
Member

@sairanjit sairanjit Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need initialBitsEncoded as a constant?

Copy link
Contributor Author

@tipusinghaw tipusinghaw Apr 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To ensure that all bits are set to zero for the newly created BSLC, we require the data to be Base64URL encoded. Please let me know if you have any alternative approaches or suggestions.

Copy link
Contributor

@GHkrishna GHkrishna Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more thing tipu, this initial bit string must not be padded as we saw in the spec, so is this created with that in mind?

N can you please confirm, for demo purpose the initial encoded list is not of the actual length we require(>120000) right?

GHkrishna
GHkrishna reviewed Apr 9, 2025
View reviewed changes
GHkrishna
GHkrishna reviewed Apr 9, 2025
View reviewed changes
GHkrishna
GHkrishna reviewed Apr 9, 2025
View reviewed changes
GHkrishna
GHkrishna reviewed Apr 9, 2025
View reviewed changes
GHkrishna
GHkrishna reviewed Apr 9, 2025
View reviewed changes
GHkrishna
GHkrishna reviewed Apr 9, 2025
View reviewed changes
GHkrishna
GHkrishna reviewed Apr 9, 2025
View reviewed changes
GHkrishna
GHkrishna reviewed Apr 9, 2025
View reviewed changes
GHkrishna
GHkrishna requested changes Apr 14, 2025
View reviewed changes
src/constants.ts
@@ -0,0 +1,2 @@
export const initialBitsEncoded = `uH4sIAAAAAAAAA-3BMQEAAADCoPVPbQwfoAAAAAAAAAAAAAAAAAAAAIC3AYbSVKsAQAAA`
Copy link
Contributor

@GHkrishna GHkrishna Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more thing tipu, this initial bit string must not be padded as we saw in the spec, so is this created with that in mind?

N can you please confirm, for demo purpose the initial encoded list is not of the actual length we require(>120000) right?

src/controllers/credentials/CredentialController.ts
*/
@Example<CredentialExchangeRecordProps>(CredentialExchangeRecordExample)
@Post('/create-offer')
public async createOffer(@Body() createOfferOptions: CreateOfferOptions) {
Copy link
Contributor

@GHkrishna GHkrishna Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since, we are referring to credential metadata, but is the metadata being stored when we issue a revocable credential?

@GHkrishna GHkrishna added the enhancement This enhances the overall experience/code quality/flows, etc label Apr 14, 2025
@tipusinghaw
refactor: resolved comments
f47325c 
Signed-off-by: Tipu_Singh <tipu.singh@ayanworks.com>
@tipusinghaw
chore:updated patch version
217e738 
Signed-off-by: Tipu_Singh <tipu.singh@ayanworks.com>
@tipusinghaw
added logs to debug the issue
8cd194e 
Signed-off-by: Tipu_Singh <tipu.singh@ayanworks.com>
@sairanjit sairanjit mentioned this pull request Apr 24, 2025
Draft
KambleSahil3 and others added 7 commits April 25, 2025 15:27
@KambleSahil3
chore: Update Dockerfile (#254)
8e6b463 
Signed-off-by: sahil.kamble@ayanworks.com <sahil.kamble@ayanworks.com>
Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>
Signed-off-by: Sahil Kamble <sahil.kamble@ayanworks.com>
@KambleSahil3
chore: Update Dockerfile (#256)
91137e7 
Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>
Signed-off-by: Sahil Kamble <sahil.kamble@ayanworks.com>
@KambleSahil3
feat: push docker image (#257)
57737ff 
* feat: added yml file to push docker images to github

Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>

* feat: added yml file to push docker images to github

Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>

* fix: updated cicd.yml file

Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>

* fix: renamed yml file

Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>

---------

Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>
Signed-off-by: Sahil Kamble <sahil.kamble@ayanworks.com>
@KambleSahil3
feat/push-docker-image (#258)
9fca65e 
* feat: added yml file to push docker images to github

Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>

* feat: added yml file to push docker images to github

Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>

* fix: updated cicd.yml file

Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>

* fix: renamed yml file

Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>

* chore: removed id-token and attestations

Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>

* chore: removed id-token and attestations

Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>

---------

Signed-off-by: KambleSahil3 <sahil.kamble@ayanworks.com>
Signed-off-by: Sahil Kamble <sahil.kamble@ayanworks.com>
@tipusinghaw @KambleSahil3
feat:w3c-revocation
e03573d 
Signed-off-by: Tipu_Singh <tipu.singh@ayanworks.com>
Signed-off-by: Sahil Kamble <sahil.kamble@ayanworks.com>
@tipusinghaw @KambleSahil3
refactor: removed revocation code
7b978c9 
Signed-off-by: Tipu_Singh <tipu.singh@ayanworks.com>
Signed-off-by: Sahil Kamble <sahil.kamble@ayanworks.com>
@tipusinghaw @KambleSahil3
refactore: removed constant and enum
30e6667 
Signed-off-by: Tipu_Singh <tipu.singh@ayanworks.com>
Signed-off-by: Sahil Kamble <sahil.kamble@ayanworks.com>
bhavanakarwade and others added 14 commits April 25, 2025 17:04
@bhavanakarwade @KambleSahil3
chore: Update Dockerfile (#256) (#266)
5556b5b 
feat: push docker image (#257)

* feat: added yml file to push docker images to github



* feat: added yml file to push docker images to github



* fix: updated cicd.yml file



* fix: renamed yml file



---------



feat:w3c-revocation



refactor: removed revocation code



refactore: removed constant and enum



chore: remove unnecessary package



chore: remove unwanted files



chore: remove unwanted files



chore: remove unwanted files

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Co-authored-by: KambleSahil3 <sahil.kamble@ayanworks.com>
@GHkrishna
chore: remove unwanted package (#268)
f7bfa98 
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
@tipusinghaw
refactor: updated validation for create-bslc
560f746 
Signed-off-by: Tipu_Singh <tipu.singh@ayanworks.com>
@tipusinghaw
bump: v0.5.3 to v0.5.15
97328dc 
Signed-off-by: Tipu_Singh <tipu.singh@ayanworks.com>
@tipusinghaw
bump: updated CI file
7728d0e 
Signed-off-by: Tipu_Singh <tipu.singh@ayanworks.com>
@tipusinghaw
bump: updated ubuntu version and project name
2d1e087 
Signed-off-by: Tipu_Singh <tipu.singh@ayanworks.com>
@tipusinghaw
refactor: formatted code and updated eslint config
9861b1b 
Signed-off-by: Tipu_Singh <tipu.singh@ayanworks.com>
@tipusinghaw
refactor: updated tsconfig and CI file
c9c508c 
Signed-off-by: Tipu_Singh <tipu.singh@ayanworks.com>
@tipusinghaw
fix: prettier formatting issue
7a509f0 
Signed-off-by: Tipu_Singh <tipu.singh@ayanworks.com>
@tipusinghaw
fix: logger issue
f6c31c9 
Signed-off-by: Tipu_Singh <tipu.singh@ayanworks.com>
@tipusinghaw
fixed: linting issues
2c061cb 
Signed-off-by: Tipu_Singh <tipu.singh@ayanworks.com>
@tipusinghaw
Merge branch 'bump/credo-0.5.3-to-0.5.13' of https://github.com/crede…
e814332 
…bl/credo-controller into feat/w3c-revocation
@tipusinghaw
feat: patch and tgz issue
6a68180 
Signed-off-by: Tipu_Singh <tipu.singh@ayanworks.com>
@tipusinghaw
fix: linting issue
7255fee 
Signed-off-by: Tipu_Singh <tipu.singh@ayanworks.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 5, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
11.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GHkrishna GHkrishna GHkrishna requested changes

@sairanjit sairanjit Awaiting requested review from sairanjit

Requested changes must be addressed to merge this pull request.

Assignees

@tipusinghaw tipusinghaw

Labels

enhancement This enhances the overall experience/code quality/flows, etc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tipusinghaw @sairanjit @GHkrishna @pranalidhanavade @KambleSahil3 @bhavanakarwade