Skip to content

feat: create bucket by default when bucket is enabled #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sgtoj merged 1 commit into from
Dec 2, 2025
Merged

feat: create bucket by default when bucket is enabled #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion examples/complete/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ module "securityhub_bot" {
rules_s3_bucket = {
enabled = true
create = true
name = var.rules_s3_bucket
prefix = "securityhub-rules/"
}

Expand Down
5 changes: 0 additions & 5 deletions examples/complete/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,6 @@ variable "stage" {
default = ""
}

variable "rules_s3_bucket" {
description = "S3 bucket containing automation rules"
type = string
}

variable "slack_bot_token" {
description = "Slack bot token (requires chat:write scope)"
type = string
Expand Down
2 changes: 1 addition & 1 deletion variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ variable "rules_s3_bucket" {
description = "S3 bucket configuration for storing automation rules. Set create=true to create a new bucket, or provide an existing bucket name."
type = object({
enabled = optional(bool, false)
create = optional(bool, false)
create = optional(bool, true)
name = optional(string)
prefix = optional(string, "rules/")
})
Expand Down