Skip to content

fix: temporarially remove input validation from debug set-equipment #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cryptk merged 1 commit into from
Nov 21, 2025
Merged

fix: temporarially remove input validation from debug set-equipment #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyomnilogic_local/api/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ async def async_set_equipment(
self,
pool_id: int,
equipment_id: int,
is_on: int | bool,
is_on: int | bool | str,
is_countdown_timer: bool = False,
start_time_hours: int = 0,
start_time_minutes: int = 0,
Expand Down
13 changes: 3 additions & 10 deletions pyomnilogic_local/cli/debug/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,22 +182,15 @@ def set_equipment(ctx: click.Context, bow_id: int, equip_id: int, is_on: str) ->
ensure_connection(ctx)
omni: OmniLogicAPI = ctx.obj["OMNI"]

is_on_value: int | bool | str
# Parse is_on parameter - can be bool-like string or integer
is_on_lower = is_on.lower()
if is_on_lower in ("true", "on", "yes", "1"):
is_on_value: int | bool = True
is_on_value = True
elif is_on_lower in ("false", "off", "no", "0"):
is_on_value = False
else:
# Try to parse as integer for variable speed equipment
try:
is_on_value = int(is_on)
if not 0 <= is_on_value <= 100:
click.echo(f"Error: Integer value must be between 0-100, got {is_on_value}", err=True)
raise click.Abort
except ValueError as exc:
click.echo(f"Error: Invalid value '{is_on}'. Use true/false, on/off, or 0-100 for speed.", err=True)
raise click.Abort from exc
is_on_value = is_on

# Execute the command
try:
Expand Down