Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Argparse library improvements, cross-compilation support, and several compiler fixes.
Argparse
parser.addSubcommand()) and migratechad-native.tsCLI to use it--key=valueequals syntax for options--double-dash support to stop flag parsingsetFlagValue/setOptionValueto use directarr[i] = valueinstead of rebuilding arraysCross-compilation
--targetflag with short names (linux-x64,macos-arm64, etc.) and full LLVM triple supportopt,llc, andclanginvocations--target-cpuflag and default CI tox86-64to fix SIGILL on runnersCompiler fixes
getEnumMemberValue()was returning the loop index instead of the declared value —enum { OK = 200 }produced 0 instead of 200type. Enables patterns likeif (shape.kind === "circle").getUnionCommonFieldswas returning TS types instead of LLVM types, causing type mismatchesOther
Test plan
kindfield