Open
Conversation
… classes for Yii container support, add test
…upport constructor and property injection
…ly defined), implement definition of AutowireableFactory, AutowireableInvoker and ActiveProfiles
…on with parameters injected
…ion support using native Yii DI's property injection for public and writable properties and Yii's tags based workaround for private and readonly ones. Fixes typo in factory class name. Remove some todos
# Conflicts: # composer.json # composer.lock
…ting a collection of services
* commit '6b2e6f5088a36c9e55d84be9d97d524c131f3531': Turn on assert in CI/CD (cspray#409)
Author
|
I also wanted to mention:I know that my code has to be refactored a bit and there are plenty of warnings that has to be fixed |
Owner
|
Hi, thank you so much for your contribution! Sorry, I haven't taken a look at this yet. I'll give this a review soon, we can work on clearing up any warnings, and get this merged in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I've found your library quite interesting. Thank you.
This PR adds support for DI PSR-11 compatible container of Yii 3 framework - https://github.com/yiisoft/di
Please let me know if you are interested to adding the Yii DI container support in your library. If not, just feel free to reject this PR.
I've already implemented all the stuff supported in release-2x branch. It's covered by UT as well as all the containers the library supports ATM.
Would be great to hear your thoughts about that :)
Thank you.