Skip to content

feature: Implement Cucumber::Query in-line with Java/JS implementations #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
luke-hill merged 91 commits into from
Dec 22, 2025
Merged

feature: Implement Cucumber::Query in-line with Java/JS implementations #1801

luke-hill merged 91 commits into from
Dec 22, 2025

Conversation

@luke-hill
Copy link
Contributor

@luke-hill luke-hill commented Sep 5, 2025 •
edited
Loading

Description

Initial pass at implementing the "correct" style of cucumber query inline with Java/JS implementations

Type of change

Please delete options that are not relevant.

  • Refactoring (improvements to code design or tooling that don't change behaviour)
  • New feature (non-breaking change which adds new behaviour)
  • Breaking change (will cause existing functionality to not
    work as expected)

Please add an entry to the relevant section of CHANGELOG.md as part of this pull request.

Checklist:

Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.

  • Tests have been added for any changes to behaviour of the code
  • New and existing tests are passing locally and on CI
  • bundle exec rubocop reports no offenses
  • RDoc comments have been updated
  • CHANGELOG.md has been updated

@luke-hill
Add blank query object and remove all junit formatter implementations
c69b584
@luke-hill
Comment out the rerun formatter instead
72b0f16
@luke-hill
C+P for existing query
23f7452
@luke-hill
WIP - create a simultaneous new run formatter to try get the new enve…
4616d2e 
…lope testing working for the formatter
@luke-hill
Remove trace
875d40d
@luke-hill
Alphabeticise the iVars in query
3157de5
@luke-hill
Note to self on first two items that are required
958abdb
@luke-hill
Store test case started by id in query
ba1a767
@luke-hill
Add in implementation for next query method
c6b0f4e
@luke-hill
Comment WIP about getting the iVar from query
fdd9c45
@luke-hill
Add third implementor and add notes for implemented ones
1a3700b
@luke-hill
Early terminate in #update as only one call is ever valid
5b3abf4
@luke-hill
Add readerss
f4a53da
@luke-hill
WIP - more guesswork
2615ff7
@luke-hill
WIP: Implement new repository / query interface
10466da
@luke-hill
Staging point. We now have 3 complex finders and 1 simple finder inte…
7daf0f2 
…grated with our repository and (in 2 instances, fully), functional
@luke-hill
Reached a checkpoint where we have 2 tests (running for minimal and e…
19ccbff 
…mpty) that validate find all pickles returns the correct number.

Next step is to extend this to test 3/4/5 files for JUST find all pickles
@luke-hill
Extend query to run against 4 sample ndjson files with expected answers
2c02397
@luke-hill
More tidy and added a 5th example for findAllPickles
6456f44
@luke-hill
Implement two more sub-update methods for generic update for hooks;
ec538b8
@luke-hill
Complete initial iteration for update in repository
7e79823
@luke-hill
Tidy up to use ruby writers;
a3c7254
@luke-hill
Have ChatGPT write a much more optimal iterator
583d342
@luke-hill
Use the new test iterator
832a76b
@luke-hill
Final tidy for specs;
de47515
@luke-hill
Update remaining items for the TODO markers for the enumerable items …
c66f47b 
…for pickle and test case
@luke-hill
Mark the 2*TODO items as ready for sign-off
1659c70
@luke-hill
Re-order #update according to Java impl
5e2323b
@luke-hill
Add in TODO markers for count and findAll methods
c8b3842
@luke-hill
1 all method complete
30f817f
@luke-hill
Simplify when step condition
7ba5c3e
@luke-hill
Re-ordered TODO work
328f41a
@luke-hill
Cleanup repository style as per rubocop;
4b3bb9b
@luke-hill
Fixed two queries requiring a review, needs a bit of tidying up
810eafd
@luke-hill
WIP standardisation TBD
4c9aa52
@luke-hill
Find meta is simple
24fb985
@luke-hill
Add new private DRYed up guard for message invalidity
84c3fd4
@luke-hill
Standardised all methods to start with nil check
51a7aa4
@luke-hill
Re-order and add missing message types for hash
48a206a
@luke-hill
Tidied up logic 14/25 findBy methods now complete and functional
82e6180
@luke-hill
Fix code that invoked a lVar that was not defined
2e13027
@luke-hill
Fix scope of private method def
a7d56f0
@luke-hill
Merge branch 'main' into feature/new_query
5afd132
@luke-hill
Add changelog message
fbef3ea
@luke-hill
Update rubocop
0ce6ba9
@luke-hill
Fix message builder temp issue
c07d123
@luke-hill
Remove problematic file
fd54256
@luke-hill
Fix spec execution
7021700
@luke-hill
Add testRunStarted and Finished simple finders
32d9889
@luke-hill
Checkpoint for repository attributes
53e8d72
@luke-hill
Placeholder for attachment structs
f09173f
@luke-hill
Add boilerplate for attachments and convert their struct to a hash of…
04fae54 
… array values
@luke-hill
Add note about dependency issues
13388c5
@luke-hill
Add initial strawman for test_run_duration
0b3034a
@luke-hill
Merge branch 'main' into feature/new_query
a76ab06
@luke-hill
Changelog styles
e49f5b1
@luke-hill
Remove messages warning
eb8d752
@luke-hill
Fix up duration query method
dfae896
@luke-hill luke-hill merged commit 50c3705 into main Dec 22, 2025
0 of 12 checks passed
@luke-hill luke-hill deleted the feature/new_query branch December 22, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpkorstanje mpkorstanje mpkorstanje left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@luke-hill @mpkorstanje