Use the result type 'ambiguous' for ambiguous step matches. #1815
+66
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cucumber-Messages has a separate test step result status 'AMBIGUOUS', therefore cucumber-ruby should use the test result type 'ambiguous' for ambiguous step matches.
* Use unskippable actions for ambiguous steps so they are identified also after failing steps or in dru run mode.
luke-hill
reviewed
Feb 6, 2026
Contributor
luke-hill
left a comment
luke-hill
left a comment
There was a problem hiding this comment.
5/7 files reviewed and approved. 2 files not yet looked at.
In terms of CI this failure looks related to your PR Bjorn
Contributor
|
We probably also want to pin core to have a minimum version of the last released (When I get around to it) |
luke-hill
reviewed
Feb 9, 2026
Contributor
luke-hill
left a comment
luke-hill
left a comment
There was a problem hiding this comment.
Reviewed another file and made sense of it. Only LOC I need to review now is tagged (Might need help)
|
|
||
| def activate(test_step) | ||
| test_step.with_action { raise @error } | ||
| test_step.with_unskippable_action { raise Core::Test::Result::Ambiguous, @error.message } |
Contributor
Author
There was a problem hiding this comment.
The point of using test_step.with_unskippable_action is so that also after a failed/pending/undefined/ambiguous step, an ambiguous step is marked as ambiguous. Raising the Core::Test::Result::Ambiguous is what makes the test result ambiguous
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cucumber-Messages has a separate test step result status 'AMBIGUOUS', therefore cucumber-ruby should use the test result type 'ambiguous' for ambiguous step matches.
This is specifically needed for cck v22 conformance where examples with ambiguous step matches are included (#1806).
Requires cucumber-ruby-core#311
Type of change
Please delete options that are not relevant.
Please add an entry to the relevant section of CHANGELOG.md as part of this pull request.
Checklist:
Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.
bundle exec rubocopreports no offenses