Issue with Microsoft Login. Authentication was not being registered on first click#164
Open
madhav-inspexion wants to merge 1 commit intocuongdevjs:masterfrom
Open
Issue with Microsoft Login. Authentication was not being registered on first click#164madhav-inspexion wants to merge 1 commit intocuongdevjs:masterfrom
madhav-inspexion wants to merge 1 commit intocuongdevjs:masterfrom
Conversation
…cond time for his login to register with the app. This was caused by a too early removal of the storage event listener'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked to Issue #163
Fix an issue with Microsoft where the user had to click on login a second time for his login to register with the app. This was caused by a too early removal of the 'storage' event listener
The fix is quite simple really; we just have to make sure that 'code' exists before removing the listener and then everything works perfectly.