Added function to manually reset offsets of bottomview #190
Open
PulfordJ wants to merge 3 commits intodaimajia:masterfrom
Open
Added function to manually reset offsets of bottomview #190PulfordJ wants to merge 3 commits intodaimajia:masterfrom
PulfordJ wants to merge 3 commits intodaimajia:masterfrom
Conversation
Change-Id: I9497fb07a9d29d274b6d02ff29c4610fc353225d Signed-off-by: Alexander Martinz <eviscerationls@gmail.com>
…(true, true) doesn't appear to guarentee this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
doesn't appear to guarantee this. I suspect the library assumes the user is manually closing the view and doesn't upset the offset in all or some cases. Adding manual resetting of offset allowed the use of Google Inbox like swipe-to-delete functionality:
Example listener with the new function:
Of course if you have any idea how to duplicate this functionality without exposing the extra function then go for it or I can do it with guidance/time. I would have attempted this but I think it would have risked bugging out the "smooth" close function parameter .