Remove unnecessary MIT license header from K3sContainer#421
Open
Remove unnecessary MIT license header from K3sContainer#421
Conversation
The K3sContainer implementation is not a derivative work of the Testcontainers K3s module. While both configure K3s containers, the implementations differ significantly: - Different class hierarchies (KubernetesWithKubeletContainer vs GenericContainer) - Different kubeconfig handling (custom utils vs Jackson-based) - Different feature sets (version management, node port ranges, etc.) - No shared code beyond standard K3s requirements The common configuration elements (privileged mode, tmpfs, cgroup settings) are standard K3s requirements that any K3s container implementation must use, not copyrightable expression. The MIT license header was overly cautious and potentially misleading about the relationship between the two implementations. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Hi Alex, long time no see - I hope you are well! I don't think there's any problem with this at all. I don't think I was aware of this header, and I don't have any issue with it being removed. Hope this helps! |
|
Sorry for the late reply, feel free to remove it and thanks for asking 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
During a license audit, we found that
K3sContainer.javacontains an MIT license header referencing the Testcontainers K3s module. The header was added out of caution when this implementation was created, stating the file was "loosely inspired by" the Testcontainers version.Analysis
After comparing the two implementations, there are no substantial similarities beyond standard K3s configuration requirements:
Common elements (standard K3s requirements, not copyrightable):
/runand/var/run(required by K3s)Significant differences:
KubernetesWithKubeletContainervsGenericContainerThe original Testcontainers K3s module is 70 lines with Jackson-based kubeconfig parsing. This implementation is 124 lines with a completely different architecture and feature set.
Request for Feedback
Before merging, we'd like to confirm with the Testcontainers maintainers that:
Summoning @kiview @rnorth - would appreciate your perspective on this. If you believe the MIT header should remain for any reason, we're happy to keep it.
Changes
🤖 Generated with Claude Code