Fix observations labels #52
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ability to add histogram calculation as custom output from vectorized operation? testing
|
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Throughout main plantcv we labels objects as 1-indexed (the first object is "object 1" rather than "object 0"). These changes conform the observations saved by geospatial analysis functions to also be 1-indexed.
Type of update
Is this a:
Associated issues
Reference associated issue numbers. Does this pull request close any issues?
Additional context
There's also a fix to which attribute of the
Outputsobject contains the replicate label. It should be thesampleattribute and thelabelis usually similar/the same as units. For multi-value traits, like frequency tables, it's the bin labels.For the reviewer
See this page for instructions on how to review the pull request.
plantcv-geospatial/mkdocs.ymlchangelog.md