Skip to content

Conversation

@HaleySchuhl
Copy link
Contributor

@HaleySchuhl HaleySchuhl commented Sep 10, 2025

Describe your changes
Add plot labels, which are detected from a given geojson or are numerated with the analysis label parameter as a base name. Also change the plot boundary lines to be blue, rather than red, since it's more colorblind friendly.

  • Should we wrap the labels in pcv.params.verbose logic?

November 7th updates: combine the ability to use pcv.params.sample_label AND the labels embedded within the shapefile shapes. Also, revert back to 0 indexed auto-ids since it's more consistent with how plots are labeled in QGIS.

Type of update
Is this a:

  • feature enhancement
  • bugfix to the outputs.observation sample & label behaviors

Associated issues
Reference associated issue numbers. Does this pull request close any issues?

Additional context

  • implements the plotting helper function in all analysis functions

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv-geospatial/mkdocs.yml
  • Changes to function input/output signatures added to changelog.md
  • Code reviewed
  • PR approved

@deepsource-io
Copy link

deepsource-io bot commented Sep 10, 2025

Here's the code health analysis summary for commits 79c39da..9755413. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%100%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@HaleySchuhl HaleySchuhl marked this pull request as ready for review September 11, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants