Update algorithm to crop and unwarp card in detect_color_card
#1795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"v" channel rather than rgb2gray
remove extra debugging plots
overwrite the adaptive radius if set by the user. also removing extra debugging steps
also rename variables to be more accurate given the current orientation
check matrix shape instead of labeled mask
HaleySchuhl
added
work in progress
|
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
cropped card becomes warped so loosen aspect ratio and solidity restore contour detection on the cropped color card
embed new debug images, clarify output is now a color matrix
HaleySchuhl
added
ready to review
and removed
work in progress
joshqsumner
approved these changes
Sep 19, 2025
Contributor
joshqsumner
left a comment
joshqsumner
left a comment
There was a problem hiding this comment.
Looks good, like the new debug image.
I think we could have more information about tuning these parameters but per Noah's comments in dev meeting they maybe don't belong in this PR cluttering the actual docs. Maybe we'll have a "using bad images" tutorial or something in the future where we highlight features meant to get around a bad imaging set up.
HaleySchuhl
added
work in progress
Contributor
|
Note, problem here is with detecting the white chip, color chip numbering is not consistent post-warp per Haley's lab meeting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Use polygon to help describe color cards that might be both rotated and skewed. Crop the color card detected, and then create a color matrix directly.
Type of update
Is this a:
Associated issues
Reference associated issue numbers. Does this pull request close any issues?
Additional context
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md