Add support for astrobotany color calibration stickers #1819
+611
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test that calibration with a cameratrax and astrobotany color card return similar corrected values
NMiklave
added
enhancement
|
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
joshqsumner
approved these changes
Oct 27, 2025
Contributor
joshqsumner
left a comment
joshqsumner
left a comment
There was a problem hiding this comment.
Looks good! I really like the partial detection option but I did not dig into how well the color correction works given that partial detection. Might be an interesting tangent related to #1770.
Made a few edits docs layout wise and added a function to throw an error if an aruco tag ends up with a mask in it as would happen in:
from plantcv import plantcv as pcv
pcv.params.debug = "plot"
img, _, _ = pcv.readimage("/home/josh/plantcv/tests/testdata/astrocard_img.png")
# function detects corner squares, which could be misleading without helper error function
labeled_mask = pcv.transform.detect_color_card(rgb_img=img)
nfahlgren
added
ready to review
and removed
work in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR introduces support for an alternate style of color card by setting
color_chip_size="astro"in thepcv.transformfunctionsdetect_color_card,mask_color_card, andauto_correct_color.Type of update
Is this a:
Associated issues
Related to an ongoing discussion on evaluating calibration quality, in #1770.
Additional context
This style of color card is commonly used in the astrobotany research community as a low-cost and low-mass alternative to Macbeth ColorChecker style cards. The reference matrix for these cards is set so that an image corrected with either type of card will, on average, have measurement error of RGB channels less than 2.5 (1% of full range).
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md