Skip to content

Conversation

@joshqsumner
Copy link
Contributor

Describe your changes
Added a sharpening function using unsharp masking.

Type of update
This is a new feature.

Associated issues
Closes #1824

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@joshqsumner joshqsumner added this to the PlantCV v5.0 milestone Oct 27, 2025
@joshqsumner joshqsumner added new feature New feature ideas and solutions work in progress Mark work in progress labels Oct 27, 2025
@joshqsumner joshqsumner changed the base branch from main to v5.0 October 27, 2025 16:36
@deepsource-io
Copy link

deepsource-io bot commented Oct 27, 2025

Here's the code health analysis summary for commits e8228a4..187fc66. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ Success
🎯 1 occurence resolved
View Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@joshqsumner joshqsumner added ready to review and removed work in progress Mark work in progress labels Oct 28, 2025
@joshqsumner
Copy link
Contributor Author

There was a lot of hassle with cyclic imports getting this to pass checks. I ended up changing a bunch of places where a function is imported from plantcv.plantcv into plantcv.plantcv.module and making _globals to define params/outputs. That worked eventually for this PR but it's probably indicative of something we could take more care in actually fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature New feature ideas and solutions ready to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sharpening images

2 participants