Skip to content

Fix #14421 Crash in TokenList::isFunctionHead() #8146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrchr-github wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix #14421 Crash in TokenList::isFunctionHead() #8146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d0671c
Fix #14421 Crash in TokenList::isFunctionHead()
web-flow Jan 21, 2026
8b276cb
init
web-flow Jan 21, 2026
d464e63
Fix
web-flow Jan 21, 2026
7be7c07
Format
web-flow Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/tokenize.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3343,9 +3343,12 @@ bool Tokenizer::simplifyUsing()
// function pointer
TokenList::copyTokens(tok1->next(), fpArgList, usingEnd->previous());
Token* const copyEnd = TokenList::copyTokens(tok1, start, fpQual->link()->previous());
tok1->deleteThis();
Token* leftPar = copyEnd->previous();
while (leftPar->str() != "(")
leftPar = leftPar->previous();
Token* const rightPar = copyEnd->next()->insertToken(")");
Token::createMutualLinks(tok1->next(), rightPar);
Token::createMutualLinks(leftPar, rightPar);
tok1->deleteThis();
substitute = true;
} else if (fpArgList && !fpQual && Token::Match(tok1->next(), "* const| %name%")) {
// function pointer
Expand Down
8 changes: 8 additions & 0 deletions test/testsimplifyusing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -898,6 +898,14 @@ class TestSimplifyUsing : public TestFixture {
const char expected2[] = "int ( * fp1 ) ( int ) ; int ( * const fp2 ) ( int ) ;";
ASSERT_EQUALS(expected2, tok(code2));
ASSERT_EQUALS("", errout_str());

const char code3[] = "using FP = std::string (*)();\n"
"using FPC = std::string (*const)();\n"
"FP fp;\n"
"FPC fpc{};\n";
const char expected3[] = "std :: string ( * fp ) ( ) ; std :: string ( * const fpc ) ( ) { } ;";
ASSERT_EQUALS(expected3, tok(code3));
ASSERT_EQUALS("", errout_str());
}

void simplifyUsing8970() {
Expand Down
Loading