Fix #13797 FN nullPointer with negated if-condition (regression) #8172
Conversation
test/testnullpointer.cpp
Outdated
| " return s;\n" | ||
| "}\n", dinit(CheckOptions, $.inconclusive = true)); | ||
| ASSERT_EQUALS("", errout_str()); | ||
| TODO_ASSERT_EQUALS("", |
There was a problem hiding this comment.
We already warn without the negation: if (r) ..., so I'm not sure if this should even be a TODO.
In the original ticket, g() was a library function, so maybe we could extend the configuration options there.
There was a problem hiding this comment.
Could you file a ticket about this with the todoassert keyword? Otherwise these things tend to rot.
There was a problem hiding this comment.
Turned into an ASSERT. I think we intend to warn if there are unknown functions that just might modify their arguments (hence inconclusive). As said above, #9827 is probably a library issue.
|
Those are some nice true positives. |
|
|
This seems to fix multiple tickets, see https://trac.cppcheck.net/search?q=d30f42e0da85ef23cd5efb46225a8be29b90b5f8 |
3 participants
No description provided.