Skip to content

Fix #12944 FP uninitvar reported in lambda #8237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrchr-github wants to merge 2 commits into
base: main
Choose a base branch
from
+25 −2
Open

Fix #12944 FP uninitvar reported in lambda #8237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
120c30a
Update valueflow.cpp
chrchr-github Feb 19, 2026
4d6cbf1
Update testuninitvar.cpp
chrchr-github Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/valueflow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5958,9 +5958,12 @@ static Token* findStartToken(const Variable* var, Token* start, const Library& l
}))
return first->previous();
// Compute the outer scope
while (scope && scope->nestedIn != var->scope())
while (scope && scope->nestedIn != var->scope()) {
if (scope->type == ScopeType::eLambda && !Token::simpleMatch(scope->bodyEnd, "} ("))
return start;
scope = scope->nestedIn;
if (!scope)
}
if (!scope || (scope->type == ScopeType::eLambda && !Token::simpleMatch(scope->bodyEnd, "} (")))
return start;
auto* tok = const_cast<Token*>(scope->bodyStart);
if (!tok)
Expand Down
20 changes: 20 additions & 0 deletions test/testuninitvar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6663,6 +6663,26 @@ class TestUninitVar : public TestFixture {
" return ret;\n"
"}\n");
ASSERT_EQUALS("", errout_str());

valueFlowUninit("int f() {\n" // #12944
" int i;\n"
" auto x = [&]() { return i; };\n"
" i = 5;\n"
" return x();\n"
"}\n"
"int g() {\n"
" int i;\n"
" {\n"
" auto x = [&]() { return i; };\n"
" i = 5;\n"
" return x();\n"
" }\n"
"}\n"
"int h() {\n"
" int j;\n"
" return [&]() { return j; }();\n"
"}\n");
ASSERT_EQUALS("[test.cpp:17:27]: (error) Uninitialized variable: j [uninitvar]\n", errout_str());
}

void valueFlowUninitBreak() { // Do not show duplicate warnings about the same uninitialized value
Expand Down
Loading