Skip to content

fixed #14383 - clear PATH in selfchecks and explicitly provide executable locations #8239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
firewave wants to merge 1 commit into
base: main
Choose a base branch
from
+25 −17
Open

fixed #14383 - clear PATH in selfchecks and explicitly provide executable locations #8239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions selfcheck.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,29 +3,37 @@
selfcheck_options="-q -j$(nproc) --std=c++11 --template=selfcheck --showtime=file-total -D__GNUC__ --error-exitcode=1 --inline-suppr --suppressions-list=.selfcheck_suppressions --library=gnu --inconclusive --enable=style,performance,portability,warning,missingInclude,information --exception-handling --debug-warnings --check-level=exhaustive"
cppcheck_options="-D__CPPCHECK__ -DCHECK_INTERNAL -DHAVE_RULES --library=cppcheck-lib -Ilib -Iexternals/simplecpp/ -Iexternals/tinyxml2"
gui_options="-DQT_VERSION=0x060000 -DQ_MOC_OUTPUT_REVISION=68 -DQT_CHARTS_LIB -DQT_MOC_HAS_STRINGDATA --library=qt"
ec=0
naming_options="--addon-python=$(command -v python) --addon=naming.json"

if [ -n "$1" ]; then
selfcheck_options="$selfcheck_options $1"
fi

mkdir_cmd=$(command -v mkdir)
rm_cmd=$(command -v rm)

# clear PATH to prevent unintentional process invocations
export PATH=

ec=0

# self check externals
./cppcheck $selfcheck_options externals || ec=1
# self check lib/cli
mkdir b1
./cppcheck $selfcheck_options $cppcheck_options --cppcheck-build-dir=b1 --addon=naming.json frontend || ec=1
./cppcheck $selfcheck_options $cppcheck_options --cppcheck-build-dir=b1 --addon=naming.json -Ifrontend cli || ec=1
./cppcheck $selfcheck_options $cppcheck_options --cppcheck-build-dir=b1 --addon=naming.json --enable=internal lib || ec=1
$mkdir_cmd b1
./cppcheck $selfcheck_options $cppcheck_options --cppcheck-build-dir=b1 $naming_options frontend || ec=1
./cppcheck $selfcheck_options $cppcheck_options --cppcheck-build-dir=b1 $naming_options -Ifrontend cli || ec=1
./cppcheck $selfcheck_options $cppcheck_options --cppcheck-build-dir=b1 $naming_options --enable=internal lib || ec=1
# check gui with qt settings
mkdir b2
./cppcheck $selfcheck_options $cppcheck_options $gui_options --cppcheck-build-dir=b2 --addon=naming.json -Icmake.output/gui -Ifrontend -Igui gui/*.cpp cmake.output/gui || ec=1
$mkdir_cmd b2
./cppcheck $selfcheck_options $cppcheck_options $gui_options --cppcheck-build-dir=b2 $naming_options -Icmake.output/gui -Ifrontend -Igui gui/*.cpp cmake.output/gui || ec=1
# self check test and tools
./cppcheck $selfcheck_options $cppcheck_options -Ifrontend -Icli test/*.cpp || ec=1
./cppcheck $selfcheck_options $cppcheck_options -Icli tools/dmake/*.cpp || ec=1
# triage
./cppcheck $selfcheck_options $cppcheck_options $gui_options -Icmake.output/tools/triage -Igui tools/triage/*.cpp cmake.output/tools/triage || ec=1

rm -rf b2
rm -rf b1
$rm_cmd -rf b2
$rm_cmd -rf b1

exit $ec
16 changes: 8 additions & 8 deletions selfcheck_san.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,32 +8,32 @@ selfcheck_options="$selfcheck_options $selfcheck_options_extra"
cppcheck_options="-D__CPPCHECK__ -DCHECK_INTERNAL -DHAVE_RULES --library=cppcheck-lib -Ilib -Iexternals/simplecpp/ -Iexternals/tinyxml2"
qt_options="--library=qt -DQT_VERSION=0x060000 -DQ_MOC_OUTPUT_REVISION=69 -DQT_MOC_HAS_STRINGDATA"
qt_options="$qt_options --suppress=autoNoType:*/moc_*.cpp --suppress=symbolDatabaseWarning:*/moc_*.cpp"
naming_options="--addon-python=$(command -v python) --addon=naming.json"

# clear PATH to prevent unintentional process invocations
export PATH=

ec=0

$cmake_output/bin/cppcheck $selfcheck_options \
externals \
|| ec=1

$cmake_output/bin/cppcheck $selfcheck_options $cppcheck_options \
--addon=naming.json \
$cmake_output/bin/cppcheck $selfcheck_options $cppcheck_options $naming_options \
frontend \
|| ec=1

$cmake_output/bin/cppcheck $selfcheck_options $cppcheck_options \
--addon=naming.json \
$cmake_output/bin/cppcheck $selfcheck_options $cppcheck_options $naming_options \
-Ifrontend \
cli \
|| ec=1

$cmake_output/bin/cppcheck $selfcheck_options $cppcheck_options \
--addon=naming.json \
$cmake_output/bin/cppcheck $selfcheck_options $cppcheck_options $naming_options \
--enable=internal \
lib \
|| ec=1

$cmake_output/bin/cppcheck $selfcheck_options $cppcheck_options $qt_options \
--addon=naming.json \
$cmake_output/bin/cppcheck $selfcheck_options $cppcheck_options $naming_options $qt_options \
--suppress=constVariablePointer:*/moc_*.cpp \
-DQT_CHARTS_LIB \
-I$cmake_output/gui -Ifrontend -Igui \
Expand Down
Loading