make it possible to explicitly disable the legacy TokenList constructors
#621
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmar
reviewed
Jan 19, 2026
| : TokenList(data, size-1, filenames, filename, outputList, 0) | ||
| {} | ||
| #ifdef SIMPLECPP_TOKENLIST_ALLOW_PTR | ||
| #if SIMPLECPP_TOKENLIST_ALLOW_PTR |
Owner
There was a problem hiding this comment.
If this macro is optional, I have the feeling it's better to write:
Suggested change
| #if SIMPLECPP_TOKENLIST_ALLOW_PTR | |
| #if defined(SIMPLECPP_TOKENLIST_ALLOW_PTR) && SIMPLECPP_TOKENLIST_ALLOW_PTR |
Owner
There was a problem hiding this comment.
I am not sure what the standard says about this condition if the macro is not defined.
Collaborator
Author
There was a problem hiding this comment.
The code above will make sure it is always defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also disable their usage in
main.cpp