Skip to content

Conversation

@xdustinface
Copy link
Collaborator

@xdustinface xdustinface commented Dec 22, 2025

Bumping the version to 0.41.0 and updating CHANGELOG.md and other relevant places to reflect the new release.

Summary by CodeRabbit

  • Documentation
    • Version bumped to 0.41.0
    • Expanded Dash Core version support to include 0.22.x and 0.23.x (now supports 0.18.x - 0.23.x)
    • Added comprehensive 0.41.0 changelog with Added, Changed, Removed, and Fixed sections

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 22, 2025

📝 Walkthrough

Walkthrough

Version 0.41.0 release bump applied across configuration and documentation files, including workspace version update in Cargo.toml, new changelog entry, updated Dash Core version support range (0.18.0–0.23.x), and development branch references.

Changes

Cohort / File(s) Summary
Version Bumps
Cargo.toml, dash-network/README.md, dash-spv/ARCHITECTURE.md, dash-spv/CODE_ANALYSIS_SUMMARY.md
Workspace version incremented from 0.40.0 to 0.41.0 across manifest and documentation files
Release Documentation
CHANGELOG.md
Added complete 0.41.0 release entry with Added, Changed, Removed, and Fixed sections
Supported Versions & Branch Updates
README.md, CLAUDE.md
Updated supported Dash Core versions from 0.18.0–0.21.0 to 0.18.0–0.23.x; updated development branch from v0.40-dev to v0.42-dev; removed outdated "Recent work" entries

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 From forty to forty-one we hop,
Version bumps across the top!
Dash Core twenty-three now shines bright,
Changelogs updated, all feels right,
Releases roll with carrots and cheer! 🥕

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: prepare v0.41.0 release' clearly and specifically describes the main change: preparing a version 0.41.0 release with version bumps and documentation updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bb071f5 and d69c8ed.

📒 Files selected for processing (7)
  • CHANGELOG.md
  • CLAUDE.md
  • Cargo.toml
  • README.md
  • dash-network/README.md
  • dash-spv/ARCHITECTURE.md
  • dash-spv/CODE_ANALYSIS_SUMMARY.md
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{rs,toml}

📄 CodeRabbit inference engine (CLAUDE.md)

Never hardcode network parameters, addresses, or keys

Files:

  • Cargo.toml
Cargo.toml

📄 CodeRabbit inference engine (CLAUDE.md)

The API is currently unstable (version 0.x.x) and breaking changes may occur in minor version updates

Files:

  • Cargo.toml
🧠 Learnings (20)
📓 Common learnings
Learnt from: CR
Repo: dashpay/rust-dashcore PR: 0
File: dash-spv/CLAUDE.md:0-0
Timestamp: 2025-12-16T09:03:55.811Z
Learning: Applies to dash-spv/**/*.rs : Maintain minimum Rust version (MSRV) of 1.89 and use only compatible syntax and features
Learnt from: QuantumExplorer
Repo: dashpay/rust-dashcore PR: 108
File: key-wallet/src/gap_limit.rs:291-295
Timestamp: 2025-08-21T04:45:50.436Z
Learning: The rust-dashcore project uses Rust 1.89 as evidenced by rust-version = "1.89" in dash-spv/Cargo.toml. Modern Rust features like Option::is_none_or (stabilized in 1.82) can be used safely.
Learnt from: CR
Repo: dashpay/rust-dashcore PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-22T17:59:51.097Z
Learning: Update docs and CHANGELOG if changes are user-facing
📚 Learning: 2025-12-22T17:59:51.097Z
Learnt from: CR
Repo: dashpay/rust-dashcore PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-22T17:59:51.097Z
Learning: Update docs and CHANGELOG if changes are user-facing

Applied to files:

  • CHANGELOG.md
  • README.md
📚 Learning: 2025-12-19T00:07:22.904Z
Learnt from: CR
Repo: dashpay/rust-dashcore PR: 0
File: key-wallet/CLAUDE.md:0-0
Timestamp: 2025-12-19T00:07:22.904Z
Learning: Prepare support for future Dash upgrades including Schnorr/Taproot support, descriptor wallets, multi-signature account types, and Lightning Network payment channels

Applied to files:

  • CHANGELOG.md
  • README.md
  • dash-spv/ARCHITECTURE.md
  • CLAUDE.md
📚 Learning: 2025-12-16T09:03:55.811Z
Learnt from: CR
Repo: dashpay/rust-dashcore PR: 0
File: dash-spv/CLAUDE.md:0-0
Timestamp: 2025-12-16T09:03:55.811Z
Learning: Applies to dash-spv/src/network/**/*.rs : Use DNS-first peer discovery with automatic DNS seeds (dnsseed.dash.org, testnet-seed.dashdot.io) when no explicit peers are configured; implement immediate startup with 10-second delay only for subsequent peer searches

Applied to files:

  • CHANGELOG.md
  • dash-network/README.md
📚 Learning: 2025-06-26T16:01:37.609Z
Learnt from: DCG-Claude
Repo: dashpay/rust-dashcore PR: 0
File: :0-0
Timestamp: 2025-06-26T16:01:37.609Z
Learning: The mempool tracking infrastructure (UnconfirmedTransaction, MempoolState, configuration, and mempool_filter.rs) is fully implemented and integrated in the Dash SPV client as of this PR, including client logic, FFI APIs, and tests.

Applied to files:

  • CHANGELOG.md
  • dash-spv/ARCHITECTURE.md
  • CLAUDE.md
📚 Learning: 2025-12-16T09:03:55.811Z
Learnt from: CR
Repo: dashpay/rust-dashcore PR: 0
File: dash-spv/CLAUDE.md:0-0
Timestamp: 2025-12-16T09:03:55.811Z
Learning: Applies to dash-spv/src/sync/**/*.rs : Implement sequential phase-based synchronization via SyncManager with phases progressing in order: Headers → Masternode List → Filter Headers → Filters → Blocks

Applied to files:

  • CHANGELOG.md
  • CLAUDE.md
📚 Learning: 2025-12-22T17:59:37.849Z
Learnt from: CR
Repo: dashpay/rust-dashcore PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-22T17:59:37.849Z
Learning: Applies to **/{dash-network,dash-spv,key-wallet}/**/*.rs : Use async/await for async operations in network and wallet modules

Applied to files:

  • CHANGELOG.md
  • README.md
  • CLAUDE.md
  • dash-network/README.md
📚 Learning: 2025-06-26T15:47:37.438Z
Learnt from: DCG-Claude
Repo: dashpay/rust-dashcore PR: 0
File: :0-0
Timestamp: 2025-06-26T15:47:37.438Z
Learning: Transaction IDs (txids) and block hashes in Dash are always 32 bytes and should be passed as fixed-size byte arrays in FFI interfaces, not as C strings, to avoid inefficiency and encoding issues.

Applied to files:

  • CHANGELOG.md
📚 Learning: 2025-12-16T09:03:55.811Z
Learnt from: CR
Repo: dashpay/rust-dashcore PR: 0
File: dash-spv/CLAUDE.md:0-0
Timestamp: 2025-12-16T09:03:55.811Z
Learning: Applies to dash-spv/**/*.rs : Use async/await throughout the codebase, built on tokio runtime

Applied to files:

  • CHANGELOG.md
📚 Learning: 2025-12-16T09:03:55.811Z
Learnt from: CR
Repo: dashpay/rust-dashcore PR: 0
File: dash-spv/CLAUDE.md:0-0
Timestamp: 2025-12-16T09:03:55.811Z
Learning: Applies to dash-spv/tests/**/*.rs : Organize tests into unit tests (in-module), integration tests (tests/ directory), real network tests (with live Dash Core nodes), and performance benchmarks

Applied to files:

  • CHANGELOG.md
  • CLAUDE.md
📚 Learning: 2025-12-16T09:03:55.811Z
Learnt from: CR
Repo: dashpay/rust-dashcore PR: 0
File: dash-spv/CLAUDE.md:0-0
Timestamp: 2025-12-16T09:03:55.811Z
Learning: Applies to dash-spv/**/*.rs : Maintain minimum Rust version (MSRV) of 1.89 and use only compatible syntax and features

Applied to files:

  • CHANGELOG.md
  • README.md
  • dash-spv/CODE_ANALYSIS_SUMMARY.md
  • CLAUDE.md
📚 Learning: 2025-12-19T00:07:22.904Z
Learnt from: CR
Repo: dashpay/rust-dashcore PR: 0
File: key-wallet/CLAUDE.md:0-0
Timestamp: 2025-12-19T00:07:22.904Z
Learning: Maintain backward compatibility for serialized wallets and monitor for new DIPs affecting wallet structure when updating derivation paths

Applied to files:

  • CHANGELOG.md
📚 Learning: 2025-08-21T04:45:50.436Z
Learnt from: QuantumExplorer
Repo: dashpay/rust-dashcore PR: 108
File: key-wallet/src/gap_limit.rs:291-295
Timestamp: 2025-08-21T04:45:50.436Z
Learning: The rust-dashcore project uses Rust 1.89 as evidenced by rust-version = "1.89" in dash-spv/Cargo.toml. Modern Rust features like Option::is_none_or (stabilized in 1.82) can be used safely.

Applied to files:

  • README.md
  • CLAUDE.md
  • dash-network/README.md
📚 Learning: 2025-12-19T00:07:22.904Z
Learnt from: CR
Repo: dashpay/rust-dashcore PR: 0
File: key-wallet/CLAUDE.md:0-0
Timestamp: 2025-12-19T00:07:22.904Z
Learning: Applies to key-wallet/**/address_pool/**/*.rs : Support multiple `KeySource` variants (Private, Public, NoKeySource) to enable both full wallets and watch-only wallets with the same interface

Applied to files:

  • README.md
📚 Learning: 2025-12-22T17:59:37.849Z
Learnt from: CR
Repo: dashpay/rust-dashcore PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-22T17:59:37.849Z
Learning: Applies to Cargo.toml : The API is currently unstable (version 0.x.x) and breaking changes may occur in minor version updates

Applied to files:

  • Cargo.toml
📚 Learning: 2025-12-16T09:03:55.811Z
Learnt from: CR
Repo: dashpay/rust-dashcore PR: 0
File: dash-spv/CLAUDE.md:0-0
Timestamp: 2025-12-16T09:03:55.811Z
Learning: Applies to dash-spv/src/client/**/*.rs : Use the DashSpvClient high-level API with proper configuration via ClientConfig for client initialization

Applied to files:

  • dash-spv/ARCHITECTURE.md
  • dash-network/README.md
📚 Learning: 2025-12-22T17:59:51.097Z
Learnt from: CR
Repo: dashpay/rust-dashcore PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-22T17:59:51.097Z
Learning: Cover critical parsing, networking, SPV, and wallet flows in tests; add regression tests for fixes; consider property tests with `proptest`

Applied to files:

  • CLAUDE.md
📚 Learning: 2025-12-16T09:03:55.811Z
Learnt from: CR
Repo: dashpay/rust-dashcore PR: 0
File: dash-spv/CLAUDE.md:0-0
Timestamp: 2025-12-16T09:03:55.811Z
Learning: Applies to dash-spv/tests/**/*.rs : Integration tests should gracefully handle unavailable Dash Core nodes at 127.0.0.1:9999 without failing the test suite

Applied to files:

  • CLAUDE.md
📚 Learning: 2025-12-22T17:59:51.097Z
Learnt from: CR
Repo: dashpay/rust-dashcore PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-22T17:59:51.097Z
Learning: Do not rely on exact Dash Core consensus behavior; this library is not for consensus-critical validation

Applied to files:

  • CLAUDE.md
📚 Learning: 2025-12-16T09:03:55.811Z
Learnt from: CR
Repo: dashpay/rust-dashcore PR: 0
File: dash-spv/CLAUDE.md:0-0
Timestamp: 2025-12-16T09:03:55.811Z
Learning: Applies to dash-spv/**/*.rs : Use Tokio channels for inter-component message passing between async tasks

Applied to files:

  • dash-network/README.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: SPV Components Tests
  • GitHub Check: Key Wallet Components Tests
  • GitHub Check: Core Components Tests
  • GitHub Check: RPC Tests (stable, true)
  • GitHub Check: fuzz (dash_deser_net_msg)
  • GitHub Check: Pre-commit (macos-latest)
🔇 Additional comments (8)
dash-network/README.md (1)

22-22: LGTM! Version bump aligns with release.

The dependency version correctly reflects the 0.41.0 release version bumped in the workspace Cargo.toml.

dash-spv/CODE_ANALYSIS_SUMMARY.md (1)

5-5: LGTM! Documentation version correctly updated.

The Codebase Version field properly reflects the 0.41.0 release.

Cargo.toml (1)

6-6: LGTM! Workspace version bumped for release.

The workspace version correctly advances from 0.40.0 to 0.41.0. Note that the API remains unstable (version 0.x.x), so breaking changes may occur in minor version updates as documented in the coding guidelines.

dash-spv/ARCHITECTURE.md (1)

3-3: LGTM! Architecture documentation version updated.

The version field correctly reflects the 0.41.0 release.

CLAUDE.md (2)

168-168: LGTM! Development branch correctly updated.

The development branch is properly set to v0.42-dev, which is the next development cycle after the 0.41.0 release.


175-175: LGTM! Dash Core version support expanded.

The supported version range now includes 0.18.0 through 0.23.x, which aligns with the changes in README.md.

CHANGELOG.md (1)

1-107: LGTM! Comprehensive and well-formatted changelog.

The 0.41.0 changelog entry is excellent:

  • Follows Keep a Changelog format
  • Properly categorized into Added, Changed, Removed, and Fixed sections
  • All entries include PR numbers and contributor attribution
  • Comprehensive coverage of significant changes across the project

As per coding guidelines, this properly documents user-facing changes.

README.md (1)

95-101: LGTM! Version support documentation is accurate.

README.md changes are confirmed to be consistent with CLAUDE.md, which states "Support for Dash Core versions 0.18.0 - 0.23.x". The version ranges (0.18.x through 0.23.x) are properly documented.

The wording change from "officially supported and automatically tested" to just "officially supported" is appropriate: CI integration tests against multiple Dash Core versions are currently disabled (integrations_tests job is disabled in rust.yml). The documentation now accurately reflects that these versions are supported but not actively tested in CI.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@xdustinface xdustinface force-pushed the chore/release-0.41.0 branch 3 times, most recently from 1c76683 to 90fdf04 Compare December 25, 2025 10:03
@xdustinface xdustinface changed the title chore: Release v0.41.0 chore: release v0.41.0 Dec 29, 2025
@xdustinface xdustinface changed the title chore: release v0.41.0 chore: prepare v0.41.0 release Dec 30, 2025
@xdustinface xdustinface changed the title chore: prepare v0.41.0 release chore: prepare v0.41.0 release Dec 30, 2025
@xdustinface xdustinface marked this pull request as ready for review December 30, 2025 14:55
Copy link
Collaborator

@ZocoLini ZocoLini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xdustinface xdustinface merged commit 4abb3f2 into v0.41-dev Dec 30, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants