Skip to content

Conversation

@xdustinface
Copy link
Collaborator

We currently keep track of immature transactions/UTXOs in a separate collection and try to re-process them on every new incoming block if they are matured. This seems not really necessary to me and adds a lot extra code and complexity. Instead we can just add them like every other transaction/UTXO and exclude/respect them in the interfaces to get transactions or balances imo. This requires to keep track of the synced height within the managed wallet info like added in #305.

Based on:

commit 7316f44
Author: xdustinface <xdustinfacex@gmail.com>
Date:   Tue Dec 23 10:15:10 2025 +0100

    feat: track `synced_height` per `ManagedWalletInfo`
commit 3d8117d
Author: xdustinface <xdustinfacex@gmail.com>
Date:   Wed Dec 24 08:53:01 2025 +0100

    chore: Drop unused `utxo.rs` in `key-wallet` crate
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 25, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch refactor/immature-transactions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@xdustinface xdustinface force-pushed the refactor/immature-transactions branch from b888487 to d730564 Compare December 25, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants