refactor: simplify immature transactions handling #307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently keep track of immature transactions/UTXOs in a separate collection and try to re-process them on every new incoming block if they are matured. This seems not really necessary to me and adds a lot extra code and complexity. Instead we can just add them like every other transaction/UTXO and exclude/respect them in the interfaces to get transactions or balances imo. This requires to keep track of the synced height within the managed wallet info like added in #305.
Based on:
utxo.rsinkey-walletcrate #304synced_heightperManagedWalletInfo#305