Skip to content

Conversation

@xdustinface
Copy link
Collaborator

@xdustinface xdustinface commented Dec 27, 2025

Adds license = "CC0-1.0" to fuzz/Cargo.toml and rpc-integration-test/Cargo.toml to pass cargo-deny license checks added in the CI overhaul PR #253.

Summary by CodeRabbit

  • Chores
    • Added CC0-1.0 license metadata to project package manifests across repository components.

✏️ Tip: You can customize this high-level summary in your review settings.

Adds `license = "CC0-1.0"` to `fuzz/Cargo.toml` and `rpc-integration-test/Cargo.toml` to pass cargo-deny license checks added in the CI overhaul PR #253.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 27, 2025

📝 Walkthrough

Walkthrough

Added license = "CC0-1.0" metadata to package manifests and a related script; no behavioral or runtime changes.

Changes

Cohort / File(s) Summary
License metadata addition
fuzz/Cargo.toml, rpc-integration-test/Cargo.toml
Added license = "CC0-1.0" to the [package] section in each manifest.
Related script update
fuzz/generate-files.sh
Script updated (references/outputs) to reflect the fuzz/Cargo.toml manifest change.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 I nibble metadata, neat and bright,
Two manifests wear CC0 tonight,
A tiny hop, a license clear,
Public domain — the meadow cheer! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: add missing license fields for cargo-deny audit' accurately describes the main change—adding license fields to Cargo.toml files to resolve cargo-deny audit requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/cargo-deny

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c6f8398 and bf6389a.

📒 Files selected for processing (1)
  • fuzz/generate-files.sh
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (18)
  • GitHub Check: fuzz (hashes_ripemd160)
  • GitHub Check: fuzz (hashes_sha1)
  • GitHub Check: fuzz (hashes_sha512)
  • GitHub Check: fuzz (hashes_sha256)
  • GitHub Check: SPV Components Tests
  • GitHub Check: RPC Tests (stable, true)
  • GitHub Check: fuzz (dash_deserialize_script)
  • GitHub Check: Core Components Tests
  • GitHub Check: fuzz (dash_deserialize_block)
  • GitHub Check: fuzz (hashes_json)
  • GitHub Check: fuzz (dash_outpoint_string)
  • GitHub Check: fuzz (hashes_cbor)
  • GitHub Check: fuzz (dash_deserialize_address)
  • GitHub Check: fuzz (dash_script_bytes_to_asm_fmt)
  • GitHub Check: fuzz (dash_deserialize_amount)
  • GitHub Check: fuzz (dash_deser_net_msg)
  • GitHub Check: Pre-commit (ubuntu-latest)
  • GitHub Check: Pre-commit (macos-latest)
🔇 Additional comments (1)
fuzz/generate-files.sh (1)

17-17: License field correctly added.

The license = "CC0-1.0" field is correctly placed in the [package] section of the generated fuzz/Cargo.toml and will satisfy cargo-deny audit requirements. CC0-1.0 (public domain dedication) is the standard choice across the project's test and fuzz crates.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3884314 and c6f8398.

📒 Files selected for processing (2)
  • fuzz/Cargo.toml
  • rpc-integration-test/Cargo.toml
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{rs,toml}

📄 CodeRabbit inference engine (CLAUDE.md)

Never hardcode network parameters, addresses, or keys

Files:

  • rpc-integration-test/Cargo.toml
  • fuzz/Cargo.toml
🧠 Learnings (1)
📚 Learning: 2025-12-22T17:59:37.849Z
Learnt from: CR
Repo: dashpay/rust-dashcore PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-22T17:59:37.849Z
Learning: Applies to Cargo.toml : The API is currently unstable (version 0.x.x) and breaking changes may occur in minor version updates

Applied to files:

  • rpc-integration-test/Cargo.toml
  • fuzz/Cargo.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)
  • GitHub Check: fuzz (dash_deserialize_amount)
  • GitHub Check: fuzz (dash_deserialize_script)
  • GitHub Check: fuzz (hashes_sha512_256)
  • GitHub Check: fuzz (hashes_sha1)
  • GitHub Check: fuzz (hashes_json)
  • GitHub Check: fuzz (dash_deser_net_msg)
  • GitHub Check: fuzz (hashes_sha512)
  • GitHub Check: fuzz (dash_deserialize_address)
  • GitHub Check: fuzz (dash_script_bytes_to_asm_fmt)
  • GitHub Check: fuzz (dash_deserialize_witness)
  • GitHub Check: fuzz (hashes_sha256)
  • GitHub Check: fuzz (hashes_cbor)
  • GitHub Check: fuzz (dash_deserialize_block)
  • GitHub Check: fuzz (hashes_ripemd160)
  • GitHub Check: fuzz (dash_outpoint_string)
  • GitHub Check: Key Wallet Components Tests
  • GitHub Check: Pre-commit (ubuntu-latest)
  • GitHub Check: Pre-commit (macos-latest)
  • GitHub Check: RPC Tests (stable, true)
🔇 Additional comments (1)
rpc-integration-test/Cargo.toml (1)

4-4: LGTM! License field addition satisfies cargo-deny requirements.

The CC0-1.0 license (public domain dedication) is appropriate for test code and resolves the cargo-deny audit requirement mentioned in the PR objectives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants