Skip to content

Conversation

@xdustinface
Copy link
Collaborator

@xdustinface xdustinface commented Dec 28, 2025

This fixes the mixed line ending check for Windows in the pre-commit step in #253.

mixed line ending........................................................Failed
- hook id: mixed-line-ending
- duration: 0.31s
- exit code: 1

key-wallet-manager/README.md: fixed mixed line endings
dash-spv/CODE_ANALYSIS_SUMMARY.md: fixed mixed line endings
key-wallet-ffi/tests/test_error_conversions.rs: fixed mixed line endings
dash/tests/data/serde/extended_pub_key: fixed mixed line endings
dash/src/sml/llmq_type/rotation.rs: fixed mixed line endings
dash-spv-ffi/scripts/generate_ffi_docs.py: fixed mixed line endings
hashes/src/sha256t.rs: fixed mixed line endings
key-wallet/src/transaction_checking/transaction_router/tests/helpers.rs: fixed mixed line endings
dash-spv/tests/handshake_test.rs: fixed mixed line endings
dash/src/parse.rs: fixed mixed line endings
...
...

Summary by CodeRabbit

  • Chores
    • Updated repository configuration to standardize line ending handling across all files, ensuring consistent code formatting for contributors.

✏️ Tip: You can customize this high-level summary in your review settings.

This fixes the `mixed line ending` check for Windows in the `pre-commit` step in #253.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 28, 2025

📝 Walkthrough

Walkthrough

A new .gitattributes configuration file is introduced at the repository root to enforce consistent line endings (LF) across all text files in the project, ensuring platform-agnostic consistency.

Changes

Cohort / File(s) Summary
Git Configuration
.gitattributes
New file added with settings to enforce LF line endings for all text files using text=auto eol=lf

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Hop, hop, hooray! Line endings aligned,
LF in every file, perfectly designed!
No more carriage returns to cause a fuss,
One .gitattributes to harmonize us!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding a .gitattributes file to enforce LF line endings, which directly matches the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/line-endings

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3884314 and d9de5b8.

📒 Files selected for processing (1)
  • .gitattributes
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
  • GitHub Check: fuzz (dash_deserialize_amount)
  • GitHub Check: fuzz (hashes_sha256)
  • GitHub Check: fuzz (hashes_sha1)
  • GitHub Check: fuzz (dash_outpoint_string)
  • GitHub Check: fuzz (dash_deser_net_msg)
  • GitHub Check: fuzz (hashes_sha512_256)
  • GitHub Check: fuzz (dash_deserialize_address)
  • GitHub Check: fuzz (dash_deserialize_script)
  • GitHub Check: fuzz (hashes_sha512)
  • GitHub Check: fuzz (hashes_ripemd160)
  • GitHub Check: fuzz (dash_deserialize_block)
  • GitHub Check: fuzz (dash_script_bytes_to_asm_fmt)
  • GitHub Check: fuzz (hashes_json)
  • GitHub Check: fuzz (dash_deserialize_witness)
  • GitHub Check: SPV Components Tests
  • GitHub Check: Key Wallet Components Tests
  • GitHub Check: RPC Tests (stable, true)
  • GitHub Check: Core Components Tests
  • GitHub Check: Pre-commit (ubuntu-latest)
  • GitHub Check: Pre-commit (macos-latest)
🔇 Additional comments (1)
.gitattributes (1)

1-2: Configuration looks correct and follows best practices.

The .gitattributes rule properly enforces LF line endings across all text files using Git's auto-detection. This approach is standard for cross-platform projects and should resolve the Windows mixed line ending issues.

One note for your team: After this file is merged, users will need to renormalize their local working directories to apply the rule to existing files (typically via git add --renormalize .). You may want to document this in your contribution guide or merge notes if not already covered.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants