Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1038 +/- ##
==========================================
+ Coverage 79.08% 81.54% +2.45%
==========================================
Files 78 78
Lines 4395 4395
Branches 797 797
==========================================
+ Hits 3476 3584 +108
+ Misses 743 628 -115
- Partials 176 183 +7
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jdye64
left a comment
There was a problem hiding this comment.
Cool! Thanks for this addition Ayush. All the changes look sound to me
|
@charlesbluca since this is also one of those cases which would benefit from cpu/gpu handling does it make sense to followup on this once #1117 is complete? |
|
Yeah that makes sense - also okay with merging this in as is and iterating on it in my PR if we need VALUES implemented on CPU to unblock something |
Fixes #1013
Initial attempt at supporting the Values query.
Currently limited to creating the result on cpu dataframes only but eventually plan on extending to GPU frames via some common config.