Add better partition string escaping#180
Open
gallamine wants to merge 2 commits intodask-contrib:mainfrom
Open
Add better partition string escaping#180gallamine wants to merge 2 commits intodask-contrib:mainfrom
gallamine wants to merge 2 commits intodask-contrib:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #180 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 57 57
Lines 2209 2210 +1
Branches 303 303
=========================================
+ Hits 2209 2210 +1
Continue to review full report at Codecov.
|
Collaborator
|
Thank you so much @gallamine! I have added some thoughts to gallamine#1 on that and #181. I think we need to solve both issues at the same time. |
|
Can one of the admins verify this patch? Admins can comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the #179 this PR adds string escaping to non-integer partition values. Partitions like:
will now be wrapped like
when executing the SQL