-
Notifications
You must be signed in to change notification settings - Fork 840
feat: database level default connection configuration #18886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dantengsky
wants to merge
10
commits into
databendlabs:main
Choose a base branch
from
dantengsky:feat/db-level-connection
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: database level default connection configuration #18886
dantengsky
wants to merge
10
commits into
databendlabs:main
from
dantengsky:feat/db-level-connection
+1,195
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e649fb2 to
f778e9b
Compare
fe1a632 to
1d719d7
Compare
Member
Author
|
@codex review |
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Two New Database-Level Options
DEFAULT_STORAGE_CONNECTION,DEFAULT_STORAGE_PATHThese options define the default storage connection and path for the database. Any table created in the database without explicit storage settings will inherit these database-level defaults.
You can set the options when creating the database, or adjust them later with
ALTER DATABASE.Example
Notes:
When creating a database you cannot supply only one of
DEFAULT_STORAGE_CONNECTIONorDEFAULT_STORAGE_PATH; they must appear together or both be omitted.When altering an existing database you may change one option at a time as long as the other option already exists; otherwise the command fails.
During
CREATE DATABASE/ALTER DATABASE, connection reachability and storage path permissions are validated.Updating these database-level options does not change storage parameters of existing tables; only tables created afterwards use the new defaults.
fixes: Feature Request: Database level default connection configuration #18825
Tests
Type of change
This change is