fix(query): fix stale indices in process_or #19085
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
fix(query): fix stale indices in process_or
selector keeps stale indices when enable_selector_executor is on and the predicate tree contains OR branches (your predicate has multiple ORs plus NOT EXISTS/EXISTS). Once the OR branch switches from
SelectStrategy::AlltoSelectStrategy::False,count still reflects the number of rows considered earlier, so we can end up reading false_selection entries that were never written in this block and still carry row ids from the previous block, which are outof range for the current chunk.
Tests
Type of change
This change is