Convert python wheel tests to acceptance #2396
Conversation
denik
requested review from
andrewnester,
pietern and
shreyas-goenka
as code owners
denik
force-pushed
the
denik/acc-improve-404
branch
from
cb5d4d6 to
18515e8
Compare
denik
force-pushed
the
denik/acc-python-wheel
branch
from
a74be26 to
db270e3
Compare
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
force-pushed
the
denik/acc-python-wheel
branch
from
852e8ec to
db270e3
Compare
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
force-pushed
the
denik/acc-python-wheel
branch
from
a8d2479 to
916021c
Compare
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
force-pushed
the
denik/acc-python-wheel
branch
from
270677e to
be7b6a9
Compare
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
force-pushed
the
denik/acc-python-wheel
branch
from
60c5697 to
fe50cb1
Compare
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
left a comment
pietern
left a comment
There was a problem hiding this comment.
LGTM
Leaving the stamp of approval to @andrewnester.
|
|
||
| if args.expect is not None: | ||
| if args.expect != len(result): | ||
| sys.exit(f"Expected {args.expect}, got {len(result)}") |
There was a problem hiding this comment.
The inclusion of an expectation in this command feels off.
Could we compose this with a function/command/helper that asserts on the number of lines in an output?
There was a problem hiding this comment.
Well, this is not a generic command, this is an acceptance test helper. Given its narrow context, I think it's okay.
If we see more use cases where a separate line-counting script would makes things simpler, we can always extract that.
| type: whl | ||
| path: "./my_test_code" | ||
| build: "python3 setup.py bdist_wheel" | ||
| build: python setup.py bdist_wheel |
There was a problem hiding this comment.
There is no 'python3' in virtualenv on Windows (as we learned in #2034).
| Deployment complete! | ||
| Updating deployment state... | ||
| Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/python-wheel/default/files... | ||
| Uploading my_test_code-0.0.1-py3-none-any.whl... |
There was a problem hiding this comment.
The order is a bit confusing now, shall we do the package name replacement instead in these lines and then the output will be determenistic?
There was a problem hiding this comment.
I agree it's not ideal. I see this as -- we record a set of steps to be taken, ignoring the order.
do the package name replacement
I'd rather see the names, given that we focus on multiple wheels being supported there. If we replace both, we won't catch situation if it uploaded one wheel twice instead of two separate wheels once.
Changes
Rewrite bundle/tests/python_wheel_test.go into acceptance tests. The same configs are used, but the test now runs 'bundle deploy' and in addition to checking the files on the file system, also checks that the files were uploaded and records jobs/create request.
There is a new test helper bin/find.py which filters out paths based on regex, asserts on number of expected results. I've added it because 'find' on Windows behaves differently, so this helps avoid cross-platform differences.