[Python] Reformat variable regex #2484
Conversation
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
libs/dyn/dynvar/ref.go
Outdated
| var ( | ||
| // Regex should be in sync with _variable_regex in Python code. | ||
| // | ||
| // LINT.IfChange |
There was a problem hiding this comment.
I like this. For the Python version, could you add a more explicit comment for maintainers that they should keep the two in sync?
There was a problem hiding this comment.
Makes sense, fixed
There was a problem hiding this comment.
What acts on these annotations?
There was a problem hiding this comment.
We don't have implementation in GitHub actions. Some open source projects, for instance, Chromium, implement it. So this comment only captures intent. I wasn't able to find open source implementation
There was a problem hiding this comment.
Can you update it to some loud instruction instead?
The formatting makes me think it is taken care of automatically.
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
kanterov
requested review from
andrewnester,
denik,
pietern and
shreyas-goenka
as code owners
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
left a comment
pietern
left a comment
There was a problem hiding this comment.
Thanks!
The effective regex is slightly changed, it now allows a sequence of multiple dashes or underscores, where it didn't before.
Changes
Reformat variable regex in Python code to follow Golang. The effective regex is not changed.
Why
We need to keep both regexes in sync.
Tests
Using existing tests and manually inspecting resulting regex.