Skip to content

[Python] Simplify conf loading #2486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pietern merged 1 commit into from
Mar 13, 2025
Merged

[Python] Simplify conf loading #2486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions experimental/python/databricks/bundles/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import os.path
import sys
from copy import deepcopy
from dataclasses import dataclass, field, replace
from dataclasses import dataclass, field, fields, replace
from typing import Callable, Optional, TextIO

from databricks.bundles.core import Bundle, Diagnostics, Location, Resources
Expand Down Expand Up @@ -35,7 +35,7 @@ class _Conf:

@classmethod
def from_dict(cls, d: dict) -> "_Conf":
known_keys = {"resources", "mutators", "venv_path"}
known_keys = [f.name for f in fields(cls)]
unknown_keys = d.keys() - known_keys

if unknown_keys:
Expand Down
30 changes: 30 additions & 0 deletions experimental/python/databricks_tests/test_build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
from databricks.bundles.build import (
_append_resources,
_Args,
_Conf,
_load_object,
_parse_args,
_parse_bundle_info,
Expand Down Expand Up @@ -266,3 +267,32 @@ def test_parse_args_unknown():
locations=None,
unknown_args=["--unknown"],
)


def test_conf_from_dict():
actual = _Conf.from_dict(
{
"resources": [
"resources:load_resources",
"resources:load_more_resources",
],
"mutators": [
"resources:add_notifications",
"resources:add_more_notifications",
],
"venv_path": "venv",
"unknown": "unknown",
}
)

assert actual == _Conf(
resources=[
"resources:load_resources",
"resources:load_more_resources",
],
mutators=[
"resources:add_notifications",
"resources:add_more_notifications",
],
venv_path="venv",
)
Loading