[Python] Fix issues with multiple mutators #2509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
kanterov
requested review from
andrewnester,
denik,
pietern and
shreyas-goenka
as code owners
pietern
approved these changes
Mar 18, 2025
| ("resources", "jobs", resource_name), location | ||
| ) | ||
| resources.jobs[resource_name] = new_job | ||
| job = new_job |
Contributor
There was a problem hiding this comment.
Per the comment above, it is not possible to detect in-place mutations, but this doesn't do anything to prevent them. Is that correct?
Collaborator
Author
There was a problem hiding this comment.
Right. I will add tests for it. If the object is mutated but not copied, a mutation will have an effect, but we aren't going to record LOC changes. We can potentially detect mutation by comparing it to deep copy or hashing objects, but it will introduce an additional overhead.
|
|
||
| @job_mutator | ||
| def add_first_tag(bundle: Bundle, job: Job) -> Job: | ||
| tags = bundle.resolve_variable(job.tags) |
Contributor
There was a problem hiding this comment.
Why call resolve_variable here?
Collaborator
Author
There was a problem hiding this comment.
It's because of types, job.tags can potentially refer to a variable, while it isn't possible in practice.
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix issues with bundles using multiple mutators.
Previously, we didn't correctly chain output between them.
Tests