[Python] Add tests for recursive imports #2533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
kanterov
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
reviewed
Mar 21, 2025
| Naive implementation can have depenency due to typing. To break it we should be | ||
| using TYPE_CHECKING imports. Otherwise, there is a cycle between | ||
| databricks.bundles.core.Resource and databricks.bundles.jobs.Job | ||
| (or other resources). |
Contributor
There was a problem hiding this comment.
I don't fully understand this paragraph, can you rephrase?
| original_modules = sys.modules.copy() | ||
|
|
||
| for module in original_modules.keys(): | ||
| if module.startswith("databricks.bundles"): |
Contributor
There was a problem hiding this comment.
Same as below (can be a constant).
Suggested change
| if module.startswith("databricks.bundles"): | |
| if module.startswith("databricks.bundles."): |
kanterov
force-pushed
the
python-avoid-recursive-imports
branch
from
e196ef9 to
9b491b9
Compare
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
kanterov
commented
Mar 25, 2025
| "pytest-cov==5.0.0", | ||
| "pytest==8.3.3", | ||
| "ruff==0.6.8", | ||
| "ruff==0.9.1", |
Collaborator
Author
There was a problem hiding this comment.
It's necessary because otherwise ruff in GH actions doesn't agree with ruff in experimental/python
Contributor
There was a problem hiding this comment.
(ideally this is a separate PR)
Collaborator
Author
|
@pietern, thanks for the suggestions. I've refactored the code and comments to make it more straightforward. |
pietern
approved these changes
Mar 25, 2025
| "pytest-cov==5.0.0", | ||
| "pytest==8.3.3", | ||
| "ruff==0.6.8", | ||
| "ruff==0.9.1", |
Contributor
There was a problem hiding this comment.
(ideally this is a separate PR)
kanterov
force-pushed
the
python-avoid-recursive-imports
branch
from
aac98a4 to
70b3edd
Compare
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add tests for recursive imports.
Right now, we have carefully crafted all imports so it isn't a problem. We need tests to avoid regressions. For example, previously, we had a problem with importing from
databricks.bundles.jobsbeforedatabricks.bundles.coreresulted in errors. And introducing such regression in the code doesn't break any existing tests.Tests
Unit test