Skip to content

Include whitespace check in 'make' and 'make ws' #2630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
denik merged 1 commit into from
Apr 2, 2025
Merged

Include whitespace check in 'make' and 'make ws' #2630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ jobs:
# Exit with status code 1 if there are differences (i.e. unformatted files)
git diff --exit-code
- name: Run whitespace check
run: python tools/validate_whitespace.py
run: make ws

validate-bundle-schema:
needs: cleanups
Expand Down
7 changes: 5 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
default: vendor fmt lint tidy
default: vendor fmt lint tidy ws

PACKAGES=./acceptance/... ./libs/... ./internal/... ./cmd/... ./bundle/... .

Expand All @@ -20,6 +20,9 @@ fmt:
ruff format -qn
golangci-lint fmt

ws:
./tools/validate_whitespace.py

test:
${GOTESTSUM_CMD} -- ${PACKAGES}

Expand Down Expand Up @@ -65,4 +68,4 @@ generate:
[ ! -f tagging.py ] || mv tagging.py internal/genkit/tagging.py
[ ! -f .github/workflows/next-changelog.yml ] || rm .github/workflows/next-changelog.yml

.PHONY: lint tidy lintcheck fmt test cover showcover build snapshot vendor schema integration integration-short acc-cover acc-showcover docs
.PHONY: lint tidy lintcheck fmt test cover showcover build snapshot vendor schema integration integration-short acc-cover acc-showcover docs ws
Loading