[Python] Add generated code for pipelines #2639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanterov
force-pushed
the
python-pipelines
branch
from
fccb903 to
40427d4
Compare
kanterov
force-pushed
the
python-pipelines
branch
from
40427d4 to
2aabe4c
Compare
kanterov
changed the title
kanterov
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
kanterov
force-pushed
the
python-pipelines
branch
from
8a4e6b1 to
eaebb55
Compare
Collaborator
Author
|
@pietern Good catch, the code implementing merging of JSON schema didn't work correctly after rebase. I've fixed it now All necessary changes are in https://github.com/databricks/cli/tree/codegen-all, but it needs to be split into multiple PRs. It would be great if we could merge the first PR with codegen first and iterate on top of it. |
Contributor
|
Thanks for clarifying. The first codegen PR has some small comments that should be easy to address + merge. Are you saying the tree you link has a bunch of changes stacked on top of what's in #2507? |
pietern
approved these changes
Apr 9, 2025
Collaborator
Author
|
@pietern there are a few changes needed:
|
There are warnings because the same classes are included into jobs and pipeline packages. We will fix it when we change code generation to vendor compute package into each resource using it. The output for docs already looks correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add generated code for pipelines support introduced in #2574