[Python] Update jobs code #2656
Conversation
kanterov
force-pushed
the
update-jobs-python
branch
from
4587e10 to
aa3321c
Compare
kanterov
force-pushed
the
update-jobs-python
branch
from
aa3321c to
2ce841e
Compare
kanterov
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
| "JobParameterDefinition", | ||
| "JobParameterDefinitionDict", | ||
| "JobParameterDefinitionParam", | ||
| "JobPermission", |
There was a problem hiding this comment.
From your summary:
Rename jobs.Permission into jobs.JobPermission to avoid confusion, following the spec.
I don't fully understand the mechanics here yet, how is this generated? And is there a README covering that for maintainers somewhere?
There was a problem hiding this comment.
JobPermission is fixed in #2642, I've just generated the code using effective jsonschema
| ) | ||
|
|
||
| if TYPE_CHECKING: | ||
| from typing_extensions import Self |
There was a problem hiding this comment.
Btw, tangential question, what error do we show for Python <3.11, where things like these extensions are not available?
There was a problem hiding this comment.
This branch will be only evaluated by tools like pyright/mypy that comes with typing_extensions. We could have added typing_extensions as a dependency, but we don't need it during runtime.
There was a problem hiding this comment.
That's fine, this is just a tangential question, but I'm still interested in the answer — what happens if you try to use jobs as code with Python <3.11?
There was a problem hiding this comment.
It works, our acceptance tests run with Python 3.10
There was a problem hiding this comment.
discussed offline: there's metadata preventing installation for <3.10
lennartkats-db
left a comment
lennartkats-db
left a comment
There was a problem hiding this comment.
This looks good, but please follow up with READMEs or maintainers!
|
@pietern There is no strong dependency, code generator special-cased JobPermission. To remove special-casing we should update JSON schema |
|
@kanterov But this change doesn't touch the codegen? |
|
@pietern because the PR with codegen is still being reviewed |
Changes
Update Python code from the latest json schema.
Rename
jobs.Permissionintojobs.JobPermissionto avoid confusion, following the spec.Annotate features in a preview with "EXPERIMENTAL" and exclude them from the documentation.