[Python] Remove one-ofs and default values #2670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanterov
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
Merged
pietern
approved these changes
Apr 8, 2025
| """ | ||
|
|
||
| timezone_id: VariableOr[str] = "UTC" | ||
| pause_status: VariableOrOptional[PauseStatus] = None |
Contributor
There was a problem hiding this comment.
Curious -- what triggered reordering?
Collaborator
Author
There was a problem hiding this comment.
required fields must come first. Previously the field was not required because it had a default value.
kanterov
added a commit
that referenced
this pull request
Apr 8, 2025
## Changes Remove one-ofs and default values until they become a part of the JSON schema. ## Why It allows full generating Python code from JSON schema without overrides and removes cases where bundle configuration can't be created as a Python object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Remove one-ofs and default values until they become a part of the JSON schema.
Why
It allows full generating Python code from JSON schema without overrides and removes cases where bundle configuration can't be created as a Python object.