[Python] Add release workflow #2691
Conversation
kanterov
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
shreyas-goenka
left a comment
shreyas-goenka
left a comment
There was a problem hiding this comment.
lgtm, just one question
|
|
||
| needs: goreleaser | ||
|
|
||
| environment: release |
There was a problem hiding this comment.
Why does this need access to the release environment token?
There was a problem hiding this comment.
It's specified in trusted publishing settings in PyPi package deployment settings to avoid cases when package gets accidentially published
There was a problem hiding this comment.
Please add a comment to document this assertion.
Since the workflow doesn't use secrets, someone may remove this if they don't know about the assertion made by PyPI for OIDC purposes.
There was a problem hiding this comment.
Clarified in comments
There was a problem hiding this comment.
Can you include that this is part of the OIDC assertion in PyPI?
Docs: https://docs.pypi.org/trusted-publishers/creating-a-project-through-oidc/
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Changes
Add release workflow to publish
databricks-bundlesPyPi packageShould be merged after #2676
Why
It publishes PyPi package that is co-versioned with CLI