[Python] Fix broken uv.lock #2731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
kanterov
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
pietern
approved these changes
Apr 16, 2025
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
pushed a commit
that referenced
this pull request
Apr 24, 2025
## Changes Update `uv.lock` during tagging and fix `uv.lock` broken during the previous release. Previously, we used the genkit version substitution mechanism, which didn't work because it replaced all versions in the UV lock file, and we reverted it in #2731 ## Why Having an outdated `uv.lock` breaks Python builds after release. ## Tests Not tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix uv.lock that was broken during release process due to genkit using wildcards.
Temporarily disable updating uv.lock in genkit until we find a solution. Likely the solution will be updating uv.lock in the same workflow where we add
+devsuffix.