Skip to content

Conversation

@kanterov
Copy link
Collaborator

Changes

Fix load_resources_from_current_package_module to produce 1-based column offsets instead of 0-based.

Enforce that all locations have 1-based column and line numbers, and clearly document their semantics.

Why

VSCode fails to display resources declared in Python code:

Illegal argument: character must be non-negative

The problem didn't affect resources added through Resources.add_job and Resources.add_pipeline because these methods implement 1-based indexing.

Tests

Unit tests

@kanterov kanterov temporarily deployed to test-trigger-is April 24, 2025 11:29 — with GitHub Actions Inactive
@kanterov kanterov marked this pull request as ready for review April 24, 2025 12:57
@kanterov kanterov temporarily deployed to test-trigger-is April 24, 2025 12:59 — with GitHub Actions Inactive
@kanterov kanterov temporarily deployed to test-trigger-is April 24, 2025 13:04 — with GitHub Actions Inactive
@kanterov
Copy link
Collaborator Author

kanterov commented Apr 24, 2025

@pietern I also updated changelog

@kanterov kanterov enabled auto-merge April 24, 2025 13:08
@kanterov kanterov added this pull request to the merge queue Apr 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Apr 24, 2025
@kanterov kanterov temporarily deployed to test-trigger-is April 24, 2025 14:15 — with GitHub Actions Inactive
@kanterov kanterov added this pull request to the merge queue Apr 24, 2025
Merged via the queue into main with commit bf6858d Apr 24, 2025
16 checks passed
@kanterov kanterov deleted the fix-python-locations branch April 24, 2025 16:41
deco-sdk-tagging bot added a commit that referenced this pull request Apr 30, 2025
## Release v0.250.0

### Notable Changes
* Added inline script execution support to bundle run. You can now run scripts in the same authentication context as a DAB using the databricks bundle run command. ([#2413](#2413))

### Dependency updates
* Upgrade TF provider to 1.75.0 ([#2775](#2775))
* Upgrade Go SDK to 0.65.0 ([#2786](#2786))

### CLI
* Added `databricks apps run-local` command to run Databricks apps locally ([#2555](#2555))

### Bundles
* Raise an error when Unity Catalog volumes are used for paths other than artifacts ([#2754](#2754))
* Fixed issue with jobs and pipelines declared in Python not showing in "Bundle resource explorer" in VSCode ([#2764](#2764))
* Made `experimental/python/mutators` and `experimental/python/resources` fields optional in JSON schema ([#2761](#2761))
* Annotated deprecated fields in JSON schema ([#2770](#2770))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants