Skip to content

Generated new Python types #2827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewnester merged 2 commits into from
May 7, 2025
Merged

Generated new Python types #2827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76146c8
Generated new Python types
andrewnester May 7, 2025
7f4579e
included in make file
andrewnester May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,5 +70,6 @@ generate:
genkit update-sdk
[ ! -f tagging.py ] || mv tagging.py internal/genkit/tagging.py
[ ! -f .github/workflows/next-changelog.yml ] || rm .github/workflows/next-changelog.yml
pushd experimental/python && make codegen
Copy link
Contributor

@shreyas-goenka shreyas-goenka May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why pushd vs cd?

Copy link
Contributor

@shreyas-goenka shreyas-goenka May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we use popd anywhere, lets use cd here?

Copy link
Contributor

@shreyas-goenka shreyas-goenka May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm, I see this is what @kanterov recommends. Not sure why though.


.PHONY: lint tidy lintcheck fmt test cover showcover build snapshot vendor schema integration integration-short acc-cover acc-showcover docs ws
4 changes: 0 additions & 4 deletions experimental/python/databricks/bundles/jobs/_models/authentication_method.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@


class AuthenticationMethod(Enum):
"""
:meta private: [EXPERIMENTAL]
"""

OAUTH = "OAUTH"
PAT = "PAT"

Expand Down
4 changes: 1 addition & 3 deletions experimental/python/databricks/bundles/jobs/_models/power_bi_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@

@dataclass(kw_only=True)
class PowerBiModel:
"""
:meta private: [EXPERIMENTAL]
"""
""""""

authentication_method: VariableOrOptional[AuthenticationMethod] = None
"""
Expand Down
4 changes: 1 addition & 3 deletions experimental/python/databricks/bundles/jobs/_models/power_bi_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@

@dataclass(kw_only=True)
class PowerBiTable:
"""
:meta private: [EXPERIMENTAL]
"""
""""""
Copy link
Contributor

@pietern pietern May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kanterov Can you take a look at why this yields an empty doc block?

Copy link
Collaborator

@kanterov kanterov May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pietern it works as intended, class doesn't have experimental annotation and no description in JSON schema

Copy link
Contributor

@pietern pietern May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't empty docstrings be omitted from the output instead?

Copy link
Collaborator

@kanterov kanterov May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I remember missing class doc string breaks the parsing of field doc strings

Copy link
Contributor

@pietern pietern May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, thanks for clarifying

Copy link
Collaborator

@kanterov kanterov May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it's still needed. I there was a problem with VSCode, but I have found that it's resolved now. Databricks SDK doesn't add empty doc strings, at least we should keep both consistent, I will create a PR to remove empty doc strings.


catalog: VariableOrOptional[str] = None
"""
Expand Down
4 changes: 1 addition & 3 deletions experimental/python/databricks/bundles/jobs/_models/power_bi_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,7 @@

@dataclass(kw_only=True)
class PowerBiTask:
"""
:meta private: [EXPERIMENTAL]
"""
""""""

connection_resource_name: VariableOrOptional[str] = None
"""
Expand Down
4 changes: 0 additions & 4 deletions experimental/python/databricks/bundles/jobs/_models/storage_mode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@


class StorageMode(Enum):
"""
:meta private: [EXPERIMENTAL]
"""

DIRECT_QUERY = "DIRECT_QUERY"
IMPORT = "IMPORT"
DUAL = "DUAL"
Expand Down
4 changes: 0 additions & 4 deletions experimental/python/databricks/bundles/jobs/_models/task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,8 +215,6 @@ class Task:

power_bi_task: VariableOrOptional[PowerBiTask] = None
"""
:meta private: [EXPERIMENTAL]

The task triggers a Power BI semantic model update when the `power_bi_task` field is present.
"""

Expand Down Expand Up @@ -415,8 +413,6 @@ class TaskDict(TypedDict, total=False):

power_bi_task: VariableOrOptional[PowerBiTaskParam]
"""
:meta private: [EXPERIMENTAL]

The task triggers a Power BI semantic model update when the `power_bi_task` field is present.
"""

Expand Down
Loading