Skip to content

Conversation

@kanterov
Copy link
Collaborator

Changes

Add support for floats to Python code. Previously, attempting to deserialize a float resulted in an error.

There is only one example of a float. It's in spot_bid_max_price in compute.AzureAttributes, which was previously unsupported. Implement support for floats with all implications of precision loss.

Why

Fixes #2875

Tests

Unit tests and manually

@kanterov kanterov marked this pull request as ready for review May 14, 2025 13:00
@kanterov kanterov temporarily deployed to test-trigger-is May 14, 2025 13:02 — with GitHub Actions Inactive
@kanterov kanterov temporarily deployed to test-trigger-is May 14, 2025 13:43 — with GitHub Actions Inactive
@denik denik enabled auto-merge May 14, 2025 13:49
@denik denik disabled auto-merge May 14, 2025 14:01
@denik denik merged commit 08a88e7 into main May 14, 2025
15 of 16 checks passed
@denik denik deleted the python-fix-floats branch May 14, 2025 14:02
deco-sdk-tagging bot added a commit that referenced this pull request May 14, 2025
## Release v0.252.0

### Dependency updates
* Upgraded Go SDK to 0.69.0 ([#2867](#2867))
* Upgraded to TF provider 1.79.0 ([#2869](#2869))

### Bundles
* Remove unused fields from resources.models schema: creation\_timestamp, last\_updated\_timestamp, latest\_versions and user\_id. Using them now raises a warning ([#2828](#2828)).
* Preserve folder structure for app source code in bundle generate ([#2848](#2848))
* Fix normalising requirements file path in dependencies section ([#2861](#2861))
* Fix default-python template not to add environments when serverless=yes and include\_python=no ([#2866](#2866))
* Fix handling of Unicode characters in Python support ([#2873](#2873))
* Add support for secret scopes in DABs ([#2744](#2744))
* Make `artifacts.*.type` optional in bundle JSON schema ([#2881](#2881))
* Fix support for `spot_bid_max_price` field in Python support ([#2883](#2883))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python for DABs spot_bid_max_price azure attribute error

3 participants