Skip to content

Conversation

@anton-107
Copy link
Contributor

@anton-107 anton-107 commented Jul 18, 2025

Changes

  • Fixed pipeline resource conversion to preserve allow_duplicate_names configuration field
  • Updated schema and codegen to reflect the allow_duplicate_names field

Why

The allow_duplicate_names field was being dropped from pipeline resources during conversion, preventing users from configuring pipelines that allow duplicate names. This change ensures the field is properly preserved and passed through to the Terraform Provider

Tests

  • Added a new acceptance test

@anton-107 anton-107 temporarily deployed to test-trigger-is July 18, 2025 11:51 — with GitHub Actions Inactive
@anton-107 anton-107 temporarily deployed to test-trigger-is July 18, 2025 11:56 — with GitHub Actions Inactive
@anton-107 anton-107 temporarily deployed to test-trigger-is July 18, 2025 12:01 — with GitHub Actions Inactive
@anton-107 anton-107 temporarily deployed to test-trigger-is July 18, 2025 12:06 — with GitHub Actions Inactive
@anton-107 anton-107 changed the title Do not drop allow_duplicate_names field from the pipeline resource Preserve allow_duplicate_names field in the pipeline resource Jul 18, 2025
@anton-107 anton-107 marked this pull request as ready for review July 18, 2025 12:15
@eng-dev-ecosystem-bot
Copy link
Collaborator

eng-dev-ecosystem-bot commented Jul 18, 2025

Run: 16370847907

Env ✅‌pass 🔄‌flaky 🙈‌skip
✅‌ aws linux 305 426
✅‌ aws windows 306 425
✅‌ aws-ucws linux 411 326
✅‌ aws-ucws windows 412 325
✅‌ azure linux 305 425
✅‌ azure windows 306 424
🔄‌ azure-ucws linux 403 10 323
🔄‌ azure-ucws windows 405 9 322
✅‌ gcp linux 304 427
✅‌ gcp windows 305 426
11 failing tests:
Test Name azure-ucws linux azure-ucws windows
TestAccept/bundle/deploy/dashboard/detect-change 🔄‌flaky 🔄‌flaky
TestAccept/bundle/deploy/dashboard/nested-folders 🔄‌flaky 🔄‌flaky
TestAccept/bundle/deploy/dashboard/simple 🔄‌flaky 🔄‌flaky
TestAccept/bundle/deploy/dashboard/simple_outside_bundle_root 🔄‌flaky 🔄‌flaky
TestAccept/bundle/deploy/dashboard/simple_syncroot 🔄‌flaky 🔄‌flaky
TestAccept/bundle/deployment/bind/dashboard 🔄‌flaky 🔄‌flaky
TestAccept/bundle/deployment/bind/dashboard/recreation 🔄‌flaky 🔄‌flaky
TestDashboardAssumptions_WorkspaceImport 🔄‌flaky 🔄‌flaky
TestFetchRepositoryInfoAPI_FromRepo ✅‌pass 🔄‌flaky
TestFilerWorkspaceNotebook 🔄‌flaky ✅‌pass
TestFilerWorkspaceNotebook/scalaJupyterNb.ipynb 🔄‌flaky ✅‌pass

@anton-107 anton-107 temporarily deployed to test-trigger-is July 18, 2025 12:42 — with GitHub Actions Inactive
@anton-107 anton-107 added this pull request to the merge queue Jul 18, 2025
Merged via the queue into main with commit dec5727 Jul 18, 2025
19 checks passed
@anton-107 anton-107 deleted the anton-107/pipeline-duplicate-names branch July 18, 2025 13:31
deco-sdk-tagging bot added a commit that referenced this pull request Jul 23, 2025
## Release v0.261.0

### Notable Changes
The following CLI commands now have additional required positional arguments:
* `alerts-v2 update-alert ID UPDATE_MASK` - Update an alert (v2)
* `database update-database-instance NAME UPDATE_MASK` - Update a database instance
* `external-lineage create-external-lineage-relationship SOURCE TARGET` - Create an external lineage relationship
* `external-lineage update-external-lineage-relationship UPDATE_MASK SOURCE TARGET` - Update an external lineage relationship
* `external-metadata update-external-metadata NAME UPDATE_MASK SYSTEM_TYPE ENTITY_TYPE` - Update external metadata
* `feature-store update-online-store NAME UPDATE_MASK CAPACITY` - Update an online store
* `lakeview create-schedule DASHBOARD_ID CRON_SCHEDULE` - Create a schedule
* `lakeview create-subscription DASHBOARD_ID SCHEDULE_ID SUBSCRIBER` - Create a subscription
* `lakeview update-schedule DASHBOARD_ID SCHEDULE_ID CRON_SCHEDULE` - Update a schedule
* `network-connectivity update-private-endpoint-rule NETWORK_CONNECTIVITY_CONFIG_ID PRIVATE_ENDPOINT_RULE_ID UPDATE_MASK` - Update a private endpoint rule

### CLI
* Add required query parameters as positional arguments in CLI commands ([#3289](#3289))

### Bundles
* Fixed an issue where `allow_duplicate_names` field on the pipeline definition was ignored by the bundle ([#3274](#3274))
* Add warning for when required bundle fields are not set ([#3044](#3044))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants