Update CLI to latest API Definitions #3635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthban-db
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
parthban-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
parthban-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
parthban-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
parthban-db
force-pushed
the
parthban-db/stack/update-21sep
branch
from
48d4670 to
bb2ebce
Compare
parthban-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
parthban-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 24, 2025
## Changes Previously, it was checking only the root type, so it wasn't possible to have different properties in openapi_overrides and custom overrides of the same root type Also updated message to make it more clear: <img width="982" height="86" alt="image" src="https://github.com/user-attachments/assets/49493c88-da6e-4e2f-b61f-dfe8141e6170" /> ## Why Tests were unexpectedly failing in this PR #3635 ## Tests <!-- How have you tested the changes? --> <!-- If your PR needs to be included in the release notes for next release, add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->
parthban-db
force-pushed
the
parthban-db/stack/update-21sep
branch
from
983c355 to
3c16b39
Compare
parthban-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
parthban-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Contributor
shreyas-goenka
left a comment
shreyas-goenka
left a comment
There was a problem hiding this comment.
Looks good to me other than one comment. Looks like TF is still at 0.84? We need TF and the Go SDK to be at the same version in the CLI.
Is there a new TF release planned?
| "effective_logical_database_name": | ||
| "description": |- | ||
| PLACEHOLDER | ||
| "lifecycle": |
Contributor
There was a problem hiding this comment.
This doc string is being deleted and looks unrelated to the PR. Can we avoid deleting this?
parthban-db
force-pushed
the
parthban-db/stack/update-21sep
branch
from
0e5b587 to
a4f2857
Compare
parthban-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Contributor
Author
Go SDK v0.84.0 and v0.85.0 both use the same SHA for the API definition. So, in this case, we can have TF and CLI in different versions of the Go SDK. |
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
Changes
Update CLI to the latest API Definitions.
This PR also adds the
databricks shares listcommand manually for backward compatibility, which was removed from the API definition.Why
Tests
Existing CI.