[Python] Fix relative paths on Windows PCs with multiple drives #3718
+33
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
kanterov
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
pietern
approved these changes
Oct 6, 2025
Contributor
pietern
left a comment
pietern
left a comment
There was a problem hiding this comment.
This function appears to be used only for making locations in diagnostics relative. If it were also used to make notebook/file paths relative (e.g. spark_python_task), then not returning a relative path presents a failure mode.
Please add a comment describing how this function is supposed to be called and that it can return an absolute path. It should never be used in cases where we really need a relative path.
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix a problem in
_relativize_pathwhere it crashes on Windows if the supplied path is on a different drive from CWD.Since paths on different drives don't have anything common, we simply return the supplied path as-is.
Why
Fixes #3658
Tests
Unit tests