[Python] Move python directory #3851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
kanterov
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
Collaborator
11 failing tests:
|
pietern
approved these changes
Oct 31, 2025
Contributor
pietern
left a comment
pietern
left a comment
There was a problem hiding this comment.
I prefer moving this to bundles/python.
It's the CLI repo after all, and a top-level python directory implies it is something more (other) than bundle support.
| }, PythonMutatorPhaseLoadResources) | ||
|
|
||
| assert.Error(t, err, "experimental/pydabs is deprecated, use experimental/python instead (https://docs.databricks.com/dev-tools/bundles/python)") | ||
| assert.Error(t, err, "experimental/pydabs is deprecated, use python instead (https://docs.databricks.com/dev-tools/bundles/python)") |
Contributor
There was a problem hiding this comment.
Does this error come from Python?
Collaborator
Author
There was a problem hiding this comment.
No, it's in golang code
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
Author
|
We discussed offline that using "python" is good enough. If we reuse the "bundles" directory, it will be confusing to see a mix of GoLang and Python code in the same directory. Later, we can move the "bundles" portion of the "python" code into "python/bundles" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Move
experimental/python->pythonWhy
The Python package is no longer experimental.