Upgrade Go SDK to v0.89.0 #3870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietern
requested review from
andrewnester,
anton-107,
denik and
shreyas-goenka
as code owners
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
commented
Nov 3, 2025
| // Version could v0.0.0-dev+21e1aacf518a or just v0.0.0-dev (the latter is currently the case on Windows) | ||
| devVersionRegex = regexp.MustCompile(`0\.0\.0-dev(\+[a-f0-9]{10,16})?`) | ||
| // Matches databricks-sdk-go/0.90.0 | ||
| sdkVersionRegex = regexp.MustCompile(`databricks-sdk-go/[0-9]+\.[0-9]+\.[0-9]+`) |
Contributor
Author
There was a problem hiding this comment.
Note: this means fewer diffs in the acceptance tests where recorded requests from Terraform show up with an older/newer SDK version until the TF dep is updated.
Collaborator
11 failing tests:
|
andrewnester
reviewed
Nov 3, 2025
|
|
||
| cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) | ||
|
|
||
| cmd.Flags().BoolVar(&createReq.AllowDuplicateNames, "allow-duplicate-names", createReq.AllowDuplicateNames, `If false, deployment will fail if name conflicts with that of another pipeline.`) |
Contributor
There was a problem hiding this comment.
This seems to be quite a big of backward incompatible change, shall we call it out at least in release notes?
Contributor
Author
There was a problem hiding this comment.
Thanks for flagging! I missed it when eyeballing the diff.
I'll investigate to see what happened to the field.
Contributor
Author
There was a problem hiding this comment.
I see it's not just the flag but all flags...
Contributor
Author
There was a problem hiding this comment.
They were added by mistake in #3769.
It was corrected in a later SDK release and that's now picked up.
Contributor
Author
There was a problem hiding this comment.
These flags were never intended to be added. Both the jobs create and pipeline create commands should always take a --json because the payloads are too complex to be specified via flags.
Contributor
Author
There was a problem hiding this comment.
I included this in the PR summary and added a changelog entry.
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
approved these changes
Nov 4, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 4, 2025
## Changes * https://github.com/databricks/terraform-provider-databricks/releases/tag/v1.96.0 * https://github.com/databricks/terraform-provider-databricks/releases/tag/v1.95.0 ## Why Nominal upgrade to match the SDK version in #3870.
deco-sdk-tagging bot
added a commit
that referenced
this pull request
Nov 5, 2025
## Release v0.276.0 ### CLI * Remove previously added flags from the `jobs create` and `pipelines create` commands. ([#3870](#3870)) ### Bundles * Updated the default-python template to follow the Lakeflow conventions: pipelines as source files, pyproject.toml ([#3712](#3712)). * Fix a permissions bug adding second IS\_OWNER and causing "The job must have exactly one owner." error. Introduced in 0.274.0. ([#3850](#3850))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
See https://github.com/databricks/databricks-sdk-go/releases/tag/v0.89.0
This change removes previously added flags to the
jobs createandpipelines createcommands. These flags were not part of these commands before and were added by accident (in #3769). Because the payload for these commands is complex, they take a--jsonflag instead.